Skip to content

Comments

Upgrade expo#187

Merged
guillaumemoby merged 23 commits intomasterfrom
upgrade-expo
Sep 24, 2020
Merged

Upgrade expo#187
guillaumemoby merged 23 commits intomasterfrom
upgrade-expo

Conversation

@sallesma
Copy link
Member

@sallesma sallesma commented Jul 25, 2020

Before sending your pull-request 💌 make sure :

  • The tests are up-to-date and your code is tested

@sallesma sallesma linked an issue Jul 25, 2020 that may be closed by this pull request
@sallesma
Copy link
Member Author

sallesma commented Sep 20, 2020

1/4 errors we need to fix

On FeedbackButton (and any other component that uses an icon from @expo/vector-icons(fixed)

  console.error
    Warning: React.createElement: type is invalid -- expected a string (for built-in components) or a class/function (for composite components) but got: object. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.
    
    Check the render method of `Icon`.
        in Icon (created by Icon)
        in Icon (created by FeedbackButton)
        in View (created by View)
        in View (created by AnimatedComponent)
        in AnimatedComponent (created by ForwardRef(AnimatedComponentWrapper))
        in ForwardRef(AnimatedComponentWrapper) (created by TouchableOpacity)
        in TouchableOpacity (created by ForwardRef)
        in ForwardRef (created by FeedbackButton)
        in FeedbackButton

-> I opened an issue there : expo/vector-icons#142

On HomePage (fixed)

/home/martin/Documents/Ultimate/disc in/UltimateApp/node_modules/react-test-renderer/node_modules/scheduler/cjs/scheduler.development.js:47
        throw e;
        ^

TypeError: _reactNative.Linking.removeEventListener is not a function
    at /home/martin/Documents/Ultimate/disc in/UltimateApp/node_modules/@react-navigation/native/lib/commonjs/useLinking.native.js:186:35
    at Object.invokeGuardedCallbackImpl (/home/martin/Documents/Ultimate/disc in/UltimateApp/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:9897:10)
    at invokeGuardedCallback (/home/martin/Documents/Ultimate/disc in/UltimateApp/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:10073:31)
    at safelyCallDestroy (/home/martin/Documents/Ultimate/disc in/UltimateApp/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:10231:5)
    at /home/martin/Documents/Ultimate/disc in/UltimateApp/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:10702:21
    at unstable_runWithPriority (/home/martin/Documents/Ultimate/disc in/UltimateApp/node_modules/react-test-renderer/node_modules/scheduler/cjs/scheduler.development.js:653:12)
    at runWithPriority (/home/martin/Documents/Ultimate/disc in/UltimateApp/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:1775:10)
    at commitUnmount (/home/martin/Documents/Ultimate/disc in/UltimateApp/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:10695:15)
    at unmountHostComponents (/home/martin/Documents/Ultimate/disc in/UltimateApp/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:11074:7)
    at commitDeletion (/home/martin/Documents/Ultimate/disc in/UltimateApp/node_modules/react-test-renderer/cjs/react-test-renderer.development.js:11110:5)

In DrillPage (and other)

    console.error
      Warning: You called act(async () => ...) without await. This could lead to unexpected testing behaviour, interleaving multiple act calls and mixing their scopes. You should - await act(async () => ...);

In DrillPage (and other)

    console.error
      Warning: An update to ForwardRef(NavigationContainer) inside a test was not wrapped in act(...).
      
      When testing, code that causes React state updates should be wrapped into act(...):
      
      act(() => {
        /* fire events that update state */
      });
      /* assert on the output */
      
      This ensures that you're testing the behavior the user would see in the browser. Learn more at https://fb.me/react-wrap-tests-with-act
          in ForwardRef(NavigationContainer)
          in Provider

@sallesma sallesma marked this pull request as ready for review September 24, 2020 11:42
@guillaumemoby guillaumemoby merged commit 6bc29a0 into master Sep 24, 2020
@sallesma sallesma deleted the upgrade-expo branch September 24, 2020 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade Expo to version 38

2 participants