Skip to content

Conversation

@onerandomusername
Copy link
Contributor

Upgrade packages that don't have wheels on python 3.10 to packages that... do have wheels.

NOTE: aiohttp still requires a wheel to be built since discord.py is blocking it,
and discord.py doesn't get updates anymore.

cchardet also still requires being built.

This doesn't mean that we won't support python 3.10, but that building on 3.10 can take a slight bit longer time.

Full diff:

13c13
< cffi==1.14.6; python_version >= "3.6"
---
> cffi==1.15.0; python_version >= "3.6"
55c55
< multidict==5.1.0; python_version >= "3.6" and python_full_version >= "3.8.0"
---
> multidict==5.2.0; python_version >= "3.6" and python_full_version >= "3.8.0"
67c67
< pycares==4.0.0; python_version >= "3.6"
---
> pycares==4.1.2; python_version >= "3.6"
103c103
< yarl==1.6.3; python_version >= "3.6" and python_full_version >= "3.8.0"
---
> yarl==1.7.2; python_version >= "3.6" and python_full_version >= "3.8.0"

upgrade cffi, multidict, pycares, and yarl to versions that have 3.10 wheels
aiohttp has not been upgraded due to discord.py blocking it, and no update for dpy
@onerandomusername onerandomusername added a: dependencies Related to package dependencies and management p: high High Priority s: needs review Ready for review and merge labels Nov 19, 2021
@onerandomusername onerandomusername requested a review from a team November 19, 2021 11:32
@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #122 (c17e778) into main (f76a0bb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #122   +/-   ##
=======================================
  Coverage   70.90%   70.90%           
=======================================
  Files          33       33           
  Lines        1619     1619           
  Branches      199      199           
=======================================
  Hits         1148     1148           
  Misses        439      439           
  Partials       32       32           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f76a0bb...c17e778. Read the comment docs.

@Shivansh-007 Shivansh-007 added the skip changelog Skip the need for a changelog entry for a Pull Request label Nov 19, 2021
@onerandomusername
Copy link
Contributor Author

Skipping changelog since this does not change what pip install . will install, which installs whatever resolved packages.

@onerandomusername onerandomusername merged commit 42e8674 into main Nov 19, 2021
@onerandomusername onerandomusername deleted the upgrade-deps branch November 19, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: dependencies Related to package dependencies and management p: high High Priority s: needs review Ready for review and merge skip changelog Skip the need for a changelog entry for a Pull Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants