Skip to content

Add a brief footer with a link to the repo#37

Merged
gdude2002 merged 18 commits into
python-discord:masterfrom
schwartzadev:add-footer
Mar 17, 2018
Merged

Add a brief footer with a link to the repo#37
gdude2002 merged 18 commits into
python-discord:masterfrom
schwartzadev:add-footer

Conversation

@schwartzadev
Copy link
Copy Markdown
Contributor

@schwartzadev schwartzadev commented Mar 5, 2018

Of course, we can add to this and include whatever y'all like -- let me know if you would like to include any specifics and I'd love to add them!

specifically useful if using an IDE
maybe this also warrants an update of the wiki..
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 5, 2018

Pull Request Test Coverage Report for Build 424

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.2%

Totals Coverage Status
Change from base Build 423: 0.0%
Covered Lines: 431
Relevant Lines: 500

💛 - Coveralls

Comment thread templates/main/base.html Outdated
{% endif %}
{% block content %}{% endblock %}
<footer>
<p>Developed collaboratively on <a href="https://github.com/discord-python/site">Github</a> • 2018</p>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's generally good practise to use HTML entities with unusual characters. Helps avoid possible encoding issues.

@lemonsaurus
Copy link
Copy Markdown
Contributor

Does the UIKit add any special visual elements to the page based on this code? If so, can we see a picture in the PR of how it looks?

@lemonsaurus
Copy link
Copy Markdown
Contributor

@schwartzadev did you see this comment?

@lemonsaurus lemonsaurus added the type: question Request for clarification or further information label Mar 6, 2018
@schwartzadev
Copy link
Copy Markdown
Contributor Author

@1mn yes - I'm having trouble with my environment as of now -- maybe someone else could pull and take a screenshot?

@gdude2002
Copy link
Copy Markdown
Contributor

Here's how it looks. Needs styling for sure.

image

@schwartzadev
Copy link
Copy Markdown
Contributor Author

Here's how it looks now
sample

@lemonsaurus
Copy link
Copy Markdown
Contributor

That's not too shabby, actually.

@lemonsaurus lemonsaurus removed the type: question Request for clarification or further information label Mar 11, 2018
Comment thread templates/main/base.html Outdated
<footer>
<div class="uk-section uk-section-secondary uk-container-medium uk-text-meta">
<div class="uk-text-center">
<p>Developed collaboratively on <a href="https://github.com/discord-python/site">Github</a> • 2018</p>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The • symbol should not be a literal, but instead should use the equivalent html entity.

Copy link
Copy Markdown
Contributor

@lemonsaurus lemonsaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local_vars.env is not relevant to this PR.

@lemonsaurus
Copy link
Copy Markdown
Contributor

This seems okay to me. We can merge if someone else approves of it as well. @gdude2002, can you look over it?

Copy link
Copy Markdown
Contributor

@gdude2002 gdude2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I would have liked it to stick to the bottom of the screen when the page is too short to fill it, but honestly that isn't a massive big deal, and it's super complicated (I just gave it a try myself).

Good work!

@gdude2002 gdude2002 merged commit e6a23bb into python-discord:master Mar 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants