Auth bug fix members/owners_should_expire#401
Merged
Conversation
matthew-bass
approved these changes
Mar 27, 2026
somethingnew2-0
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The authorization check in GroupMemberResource.put did not validate group ownership/admin perms for requests that only involved members_should_expire and owners_should_expire parameters, which are passed to ModifyGroupUsers. A non-admin/owner authenticated user could send a request with empty owner/member add/remove lists but populated members_should_expire/owners_should_expire lists, bypassing the authorization.
Added check for members_should_expire and owners_should_expire to existing auth check