fix defaultAvatarIndex calculation in activity code examples #6809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthova
reviewed
Apr 22, 2024
| avatarSrc = `https://cdn.discordapp.com/avatars/${user.id}/${user.avatar}.png?size=256`; | ||
| } else { | ||
| const defaultAvatarIndex = Math.abs(Number(user.id) >> 22) % 6; | ||
| const defaultAvatarIndex = (BigInt(user.id) >> 22n) % 6n; |
Contributor
There was a problem hiding this comment.
Ooo lol yeah that makes way more sense. Great catch. We'll want to update this in the sdk example as well.
Contributor
Author
There was a problem hiding this comment.
🫡 made a PR discord/embedded-app-sdk#150
matthova
approved these changes
Apr 22, 2024
Contributor
matthova
left a comment
matthova
left a comment
There was a problem hiding this comment.
Thanks for the patch 🫡
We've updated in the sdk examples as well discord/embedded-app-sdk#151
shaydewael
pushed a commit
to Jupith/discord-api-docs
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code examples do not select the correct avatar color