-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add callout for sticker gif urls #6831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
What is the reason for them to be served from |
|
@JustinBeckwith hmm should we even have stickers in that CDN table if they aren't at the CDN base URL? if we wanna keep in table i think the callout should move up to the Image Base Url section or within an asterisk callout under the table |
|
I think this call out is specific to GIF stickers - but I defer to @jkcailteux here |
All stickers are technically in the CDN so its probably right to keep that there. Although i can see why its confusing since you can't access GIF stickers that way...
We have to do some stuff via cloudflare workers to get our media proxy to work with GIFs in this situation (without it, theres no point in even supporting GIFs for stickers), so we have to route the request through mediaproxy and have the worker look into the CDN. I think adding a comment like Justin has done here is probably fine, I'm not sure how else to make this less confusing, other than specifying the base url for every sticker type in its own section or something |
|
Oh my beloved cloudflare.. |
Apparently, some CDN URL such as avatars are already transparently routed through the media proxy despite being accessed on Maybe you can do something similar for GIF stickers when accessed over |
shaydewael
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oki well sorta confusing to me but i dont have a better option and better to have the info present
Fixes #6675