Skip to content
This repository was archived by the owner on Jan 8, 2022. It is now read-only.

feat(SlashCommandBuilder): create setDefaultPermission function#19

Merged
iCrawl merged 11 commits intodiscordjs:mainfrom
Fyko:feat/setDefaultPermission
Aug 24, 2021
Merged

feat(SlashCommandBuilder): create setDefaultPermission function#19
iCrawl merged 11 commits intodiscordjs:mainfrom
Fyko:feat/setDefaultPermission

Conversation

@Fyko
Copy link
Copy Markdown
Contributor

@Fyko Fyko commented Aug 7, 2021

Please describe the changes this PR makes and why it should be merged:
This PR creates SlashCommandBuilder#setDefaultPermission.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 7, 2021

Codecov Report

Merging #19 (dd45da5) into main (2aecbe4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #19   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        16    +1     
  Lines          144       147    +3     
  Branches        21        17    -4     
=========================================
+ Hits           144       147    +3     
Impacted Files Coverage Δ
src/interactions/slashCommands/Assertions.ts 100.00% <100.00%> (ø)
.../interactions/slashCommands/SlashCommandBuilder.ts 100.00% <100.00%> (ø)
...nteractions/slashCommands/mixins/CommandOptions.ts 100.00% <0.00%> (ø)
...s/slashCommands/mixins/CommandOptionWithChoices.ts 100.00% <0.00%> (ø)
src/interactions/slashCommands/options/number.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2aecbe4...dd45da5. Read the comment docs.

Comment thread src/interactions/slashCommands/SlashCommandBuilder.ts
Comment thread src/interactions/slashCommands/SlashCommandBuilder.ts Outdated
@Fyko Fyko requested a review from vladfrangu August 8, 2021 17:04
Copy link
Copy Markdown

@EndBug EndBug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is kind of important for slash commands, thanks!

Comment thread src/interactions/slashCommands/SlashCommandBuilder.ts Outdated
Comment thread src/interactions/slashCommands/SlashCommandBuilder.ts Outdated
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
@kyranet kyranet requested a review from vladfrangu August 22, 2021 18:59
@iCrawl iCrawl merged commit 5d53759 into discordjs:main Aug 24, 2021
Khasms pushed a commit to Khasms/builders that referenced this pull request Sep 21, 2021
@nemoralis nemoralis mentioned this pull request Sep 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants