feat(SlashCommands): add slash command builders#3
Conversation
kyranet
left a comment
kyranet
left a comment
There was a problem hiding this comment.
Many classes and many fields need to be documented, and I'm not a fan of having many classes in the same file.
| * Returns the final data that should be sent to Discord. You won't need this unless you're manually | ||
| * creating slash commands via this builder. | ||
| * | ||
| * **Note:** Calling this getter will validate required properties based on their conditions. |
There was a problem hiding this comment.
There's @note too, although we can use <warn></warn> in this organization.
There was a problem hiding this comment.
We shouldn't rely too much on docs comments too much yet honestly.
There was a problem hiding this comment.
There's
@notetoo, although we can use<warn></warn>in this organization.
warn tags don't render in any IDE that I know off either. I believe it's fine as is
There was a problem hiding this comment.
They sort of do, but I still wouldn't use them. Whats wrong with the current approach?
vladfrangu
force-pushed
the
feat/slash-commands
branch
from
2faf7c0 to
6c0aca4
Compare
Codecov Report
@@ Coverage Diff @@
## main #3 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 1 15 +14
Lines 34 137 +103
Branches 6 20 +14
==========================================
+ Hits 34 137 +103
Continue to review full report at Codecov.
|
|
This needs a rebase now. |
vladfrangu
force-pushed
the
feat/slash-commands
branch
2 times, most recently
from
fa24516 to
3417f12
Compare
chore: code reviews v1 Co-authored-by: Antonio Román <kyradiscord@gmail.com> chore: update tsconfig per requests chore: requested changes v2 chore: split files up fix: correct regexp for slash command name chore: add documentation to all properties fix: @SpaceEEC's issues related to more helpful messages fix: make null/undefined message clearer chore: coverages chore: create validation predicates once chore: cleanup `any` casts in Assertions fix: no more `as any` casts! \o/ fix: mark name and description as readonly These are mostly to prevent TS users from accidentally setting the values without using the set* methods (which handle validation) chore: update core files chore: fix rebase
vladfrangu
force-pushed
the
feat/slash-commands
branch
from
3417f12 to
7ea8a19
Compare
For safety reasons in the event I need to rebase AGAIN, I can just drop this and recreate
iCrawl
left a comment
iCrawl
left a comment
There was a problem hiding this comment.
LGTM, we should have some markdown docs/examples on some basic/advanced usage and we need to make sure to update all of this once /v9 of dapi-types lands 👍
Co-authored-by: SpaceEEC <SpaceEEC@users.noreply.github.com>
5 participants
Please describe the changes this PR makes and why it should be merged:
Building your slash commands is now easier than ever! For those that dislike the nested arrays, this might tickle your fancy!
Status and versioning classification: