Skip to content

Conversation

@suneettipirneni
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

This PR simply moves formatters out of builders into it's own package. This allows users who use formatters to not have to install the entirely of /builders.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

@vercel
Copy link

vercel bot commented Nov 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ❌ Failed (Inspect) Dec 2, 2022 at 0:50AM (UTC)
discord-js-guide ✅ Ready (Inspect) Visit Preview Dec 2, 2022 at 0:50AM (UTC)

@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #8889 (28ff906) into main (4e4cbb3) will decrease coverage by 0.71%.
The diff coverage is n/a.

❗ Current head 28ff906 differs from pull request most recent head db541fb. Consider uploading reports for the commit db541fb to get more accurate results

@@            Coverage Diff             @@
##             main    #8889      +/-   ##
==========================================
- Coverage   85.39%   84.68%   -0.72%     
==========================================
  Files          96       95       -1     
  Lines        9525     9082     -443     
  Branches     1139     1089      -50     
==========================================
- Hits         8134     7691     -443     
  Misses       1349     1349              
  Partials       42       42              
Flag Coverage Δ
brokers 65.24% <ø> (ø)
builders 98.45% <ø> (-0.21%) ⬇️
collection 100.00% <ø> (ø)
proxy 81.53% <ø> (ø)
rest 91.97% <ø> (ø)
util 100.00% <ø> (ø)
utilities 100.00% <ø> (ø)
voice 63.70% <ø> (ø)
ws 58.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/formatters/src/formatters.ts

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The evergrowing list of packages...

image
The list goes brrr

I have been considering a couple of things after this PR:

  1. Replace some of the overloads with dynamic returns.
  2. Moving sanitizers/cleaners (from mainlib) into this package.
  3. Maybe sanitize all input before formatting. (@favna and I once discussed removing formatters from Sapphire, but he told me he won't unless Discord.js's formatters sanitize their input like Sapphire does).

@suneettipirneni suneettipirneni requested review from kyranet and removed request for iCrawl and vladfrangu December 2, 2022 01:32
@Jiralite Jiralite requested review from iCrawl and vladfrangu December 2, 2022 10:13
@kodiakhq kodiakhq bot merged commit 3fca638 into discordjs:main Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants