-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat: add @discordjs/formatters
#8889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## main #8889 +/- ##
==========================================
- Coverage 85.39% 84.68% -0.72%
==========================================
Files 96 95 -1
Lines 9525 9082 -443
Branches 1139 1089 -50
==========================================
- Hits 8134 7691 -443
Misses 1349 1349
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have been considering a couple of things after this PR:
- Replace some of the overloads with dynamic returns.
- Moving sanitizers/cleaners (from mainlib) into this package.
- Maybe sanitize all input before formatting. (@favna and I once discussed removing formatters from Sapphire, but he told me he won't unless Discord.js's formatters sanitize their input like Sapphire does).
94aee6d to
28ff906
Compare

Please describe the changes this PR makes and why it should be merged:
This PR simply moves formatters out of builders into it's own package. This allows users who use formatters to not have to install the entirely of
/builders.Status and versioning classification: