Skip to content
This repository was archived by the owner on Jul 12, 2023. It is now read-only.

fix(VoiceConnection): handle nullable endpoint in voice server update payload#100

Merged
amishshah merged 3 commits into
mainfrom
fix/nullable-endpoint-voice-server
Apr 12, 2021
Merged

fix(VoiceConnection): handle nullable endpoint in voice server update payload#100
amishshah merged 3 commits into
mainfrom
fix/nullable-endpoint-voice-server

Conversation

@amishshah
Copy link
Copy Markdown
Member

Please describe the changes this PR makes and why it should be merged:

Resolves #99.

Since a voice connection can now be in a disconnected state without a close code, the close code has now been made optional.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • This PR changes the library's interface (methods or parameters added)
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 11, 2021

Codecov Report

Merging #100 (73873be) into main (686ef19) will increase coverage by 0.13%.
The diff coverage is 100.00%.

❗ Current head 73873be differs from pull request most recent head 6ecf755. Consider uploading reports for the commit 6ecf755 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
+ Coverage   63.55%   63.69%   +0.13%     
==========================================
  Files          18       18              
  Lines         804      807       +3     
  Branches      185      187       +2     
==========================================
+ Hits          511      514       +3     
  Misses        291      291              
  Partials        2        2              
Impacted Files Coverage Δ
src/VoiceConnection.ts 79.13% <100.00%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 686ef19...6ecf755. Read the comment docs.

@amishshah amishshah enabled auto-merge (squash) April 12, 2021 09:18
@amishshah amishshah merged commit 0798520 into main Apr 12, 2021
@amishshah amishshah deleted the fix/nullable-endpoint-voice-server branch April 12, 2021 09:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle null endpoints in VOICE_SERVER_UPDATE packet

2 participants