This repository was archived by the owner on Jul 12, 2023. It is now read-only.
refactor(Adapter): sendPayload now returns boolean#105
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #105 +/- ##
==========================================
- Coverage 63.69% 63.42% -0.27%
==========================================
Files 18 18
Lines 807 812 +5
Branches 181 191 +10
==========================================
+ Hits 514 515 +1
- Misses 291 295 +4
Partials 2 2
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Makes adapters easier to work with. At the moment, the only way to signal that a message cannot be sent via
sendPayloadis to destroy the whole adapter. This PR allows forsendPayloadto return false if the message can definitely not be sent, and in this case, the voice connection enters the disconnected state rather than being destroyed entirely.This means the developer has to call
voiceConnection.reconnect()once the adapter later becomes available.Status and versioning classification: