This repository was archived by the owner on Jul 12, 2023. It is now read-only.
feat: stream time statistics#75
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #75 +/- ##
==========================================
+ Coverage 28.98% 29.81% +0.83%
==========================================
Files 15 15
Lines 590 597 +7
Branches 131 132 +1
==========================================
+ Hits 171 178 +7
Misses 417 417
Partials 2 2
Continue to review full report at Codecov.
|
vladfrangu
approved these changes
Mar 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Resolves #71
Adds
playbackDurationto bothAudioPlayerandAudioResource:AudioResource.playbackDurationis incremented by 20ms every time an Opus packet is read from its underlying Opus stream. This value can be thought of as the progress through an audio track. It starts off at 0.AudioPlayer.state.playbackDurationis available in thePlaying,Paused, andAutoPausedstates. It is incremented by 20ms every time an Opus packet (whether from the audio resource, or a filler silence packet) is prepared for dispatch by the subscribers. This value can be thought of as the "real" playback time, including any transmission gaps. It resets back to 0 when playing a new resource.You can therefore derive the length of time that filler silence has been played as the difference between these two quantities.
Status and versioning classification: