This repository was archived by the owner on Jul 12, 2023. It is now read-only.
refactor: split states into a union of interfaces#76
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #76 +/- ##
==========================================
- Coverage 29.81% 29.69% -0.12%
==========================================
Files 15 15
Lines 597 596 -1
Branches 132 132
==========================================
- Hits 178 177 -1
Misses 417 417
Partials 2 2
Continue to review full report at Codecov.
|
vladfrangu
approved these changes
Mar 13, 2021
iCrawl
approved these changes
Mar 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Improves documentation for the various states of
AudioPlayer,VoiceConnection, andNetworking.An refactor was made to
AudioPlayer, where a state of a playable type is passed to the_preparePacketmethod. This allows it to increment theplaybackDurationitself without having to perform a status assertion.Status and versioning classification: