Skip to content
This repository was archived by the owner on Jul 12, 2023. It is now read-only.

feat: add ping stats#77

Merged
amishshah merged 11 commits into
mainfrom
feat/ping-stats
Mar 17, 2021
Merged

feat: add ping stats#77
amishshah merged 11 commits into
mainfrom
feat/ping-stats

Conversation

@amishshah
Copy link
Copy Markdown
Member

@amishshah amishshah commented Mar 13, 2021

Please describe the changes this PR makes and why it should be merged:

Resolves #70.

Fixes a bug in VoiceWebSocket where if no heartbeat acknowledge was ever received, then the WebSocket would continually keep heartbeating instead of disconnecting.

Adds tests to VoiceWebSocket and the new feature.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • This PR changes the library's interface (methods or parameters added)

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 13, 2021

Codecov Report

Merging #77 (34e37b4) into main (f140bd4) will increase coverage by 5.00%.
The diff coverage is 80.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
+ Coverage   44.01%   49.02%   +5.00%     
==========================================
  Files          15       15              
  Lines         602      616      +14     
  Branches      133      135       +2     
==========================================
+ Hits          265      302      +37     
+ Misses        335      312      -23     
  Partials        2        2              
Impacted Files Coverage Δ
src/VoiceConnection.ts 79.27% <0.00%> (-2.21%) ⬇️
src/networking/Networking.ts 3.93% <ø> (ø)
src/networking/VoiceWebSocket.ts 88.09% <94.44%> (+88.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f140bd4...34e37b4. Read the comment docs.

@amishshah amishshah marked this pull request as ready for review March 17, 2021 11:00
@amishshah amishshah marked this pull request as draft March 17, 2021 11:03
@amishshah
Copy link
Copy Markdown
Member Author

Converting this PR back to a draft until tests can be implemented for it.

@amishshah amishshah marked this pull request as ready for review March 17, 2021 14:07
Comment thread src/networking/__tests__/VoiceWebSocket.test.ts
@amishshah amishshah merged commit b5385fc into main Mar 17, 2021
@amishshah amishshah deleted the feat/ping-stats branch March 17, 2021 14:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support ping stats

2 participants