This repository was archived by the owner on Jul 12, 2023. It is now read-only.
feat: add ping stats#77
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #77 +/- ##
==========================================
+ Coverage 44.01% 49.02% +5.00%
==========================================
Files 15 15
Lines 602 616 +14
Branches 133 135 +2
==========================================
+ Hits 265 302 +37
+ Misses 335 312 -23
Partials 2 2
Continue to review full report at Codecov.
|
Member
Author
|
Converting this PR back to a draft until tests can be implemented for it. |
kyranet
reviewed
Mar 17, 2021
kyranet
approved these changes
Mar 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Resolves #70.
Fixes a bug in VoiceWebSocket where if no heartbeat acknowledge was ever received, then the WebSocket would continually keep heartbeating instead of disconnecting.
Adds tests to VoiceWebSocket and the new feature.
Status and versioning classification: