Skip to content
This repository was archived by the owner on Jul 12, 2023. It is now read-only.

chore: publish documentation and use typed events#84

Merged
amishshah merged 14 commits into
mainfrom
feat/docs
Mar 30, 2021
Merged

chore: publish documentation and use typed events#84
amishshah merged 14 commits into
mainfrom
feat/docs

Conversation

@amishshah
Copy link
Copy Markdown
Member

Please describe the changes this PR makes and why it should be merged:

Publishes the documentation at https://discordjs.github.io/voice/ and uses typed EventEmitters for VoiceConnection and AudioPlayer.

The documentation isn't as nice as what we have on discord.js.org so far, but it's a step in the right direction :)

@amishshah amishshah added the documentation Improvements or additions to documentation label Mar 29, 2021
@amishshah amishshah requested review from iCrawl and kyranet March 29, 2021 12:55
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 29, 2021

Codecov Report

Merging #84 (d09f83e) into main (b5385fc) will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #84   +/-   ##
=======================================
  Coverage   52.41%   52.41%           
=======================================
  Files          15       15           
  Lines         620      620           
  Branches      136      136           
=======================================
  Hits          325      325           
  Misses        293      293           
  Partials        2        2           
Impacted Files Coverage Δ
src/audio/AudioPlayerError.ts 0.00% <ø> (ø)
src/audio/AudioResource.ts 43.47% <ø> (ø)
src/joinVoiceChannel.ts 0.00% <ø> (ø)
src/util/entersState.ts 0.00% <0.00%> (ø)
src/util/generateDependencyReport.ts 0.00% <ø> (ø)
src/VoiceConnection.ts 79.27% <100.00%> (ø)
src/audio/AudioPlayer.ts 77.34% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5385fc...d09f83e. Read the comment docs.

@amishshah amishshah merged commit 4dad86c into main Mar 30, 2021
@amishshah amishshah deleted the feat/docs branch March 30, 2021 15:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant