Skip to content
This repository was archived by the owner on Jul 22, 2025. It is now read-only.

Update CodeFund Ads to use new CodeFund API #72

Merged
nlalonde merged 1 commit into from
Jan 30, 2019
Merged

Update CodeFund Ads to use new CodeFund API #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/javascripts/discourse/components/codefund-ad.js.es6
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ function loadCodeFund() {
return _promise;
}

const url = "https://codefund.io/t/s/" + propertyId + "/details.json";
const url = "https://codefund.app/properties/" + propertyId + "/funder.json";

_promise = new Promise(function(resolve, reject) {
let xhr = new XMLHttpRequest();
Expand Down
5 changes: 3 additions & 2 deletions assets/javascripts/discourse/templates/components/codefund/post-bottom.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
<span class="codefund-wrapper codefund-post-bottom">
<a href="{{adDetails.link}}" class="codefund-text" target="_blank" rel="noopener">
<a href="{{adDetails.campaignUrl}}" class="codefund-text" target="_blank" rel="noopener">
{{#if siteSettings.codefund_display_advertiser_labels}}
<span class="codefund-label">{{siteSettings.codefund_advertiser_short_label}}</span>
{{/if}}
<strong>{{adDetails.headline}}</strong> {{adDetails.description}}
<strong>{{adDetails.headline}}</strong> {{adDetails.body}}
</a>
<img src="{{adDetails.impressionUrl}}" class="codefund-pixel">
</span>
7 changes: 4 additions & 3 deletions assets/javascripts/discourse/templates/components/codefund/topic-above-post-stream.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
<span class="codefund-wrapper codefund-topic-above-post-stream">
<a href="{{adDetails.link}}" class="codefund-text" target="_blank" rel="noopener">
<a href="{{adDetails.campaignUrl}}" class="codefund-text" target="_blank" rel="noopener">
{{#if siteSettings.codefund_display_advertiser_labels}}
<span class="codefund-label">{{siteSettings.codefund_advertiser_label}}</span>
{{/if}}
<strong>{{adDetails.headline}}</strong> {{adDetails.description}}
<strong>{{adDetails.headline}}</strong> {{adDetails.body}}
</a>
<a href={{adDetails.poweredByLink}} class="codefund-powered-by" target="_blank" rel="noopener">
<a href={{adDetails.codefundUrl}} class="codefund-powered-by" target="_blank" rel="noopener">
ads via codefund.io
</a>
<img src="{{adDetails.impressionUrl}}" class="codefund-pixel">
</span>
7 changes: 4 additions & 3 deletions assets/javascripts/discourse/templates/components/codefund/topic-above-suggested.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
<span class="codefund-wrapper codefund-topic-above-suggested">
<a href="{{adDetails.link}}" class="codefund-text" target="_blank" rel="noopener">
<a href="{{adDetails.campaignUrl}}" class="codefund-text" target="_blank" rel="noopener">
{{#if siteSettings.codefund_display_advertiser_labels}}
<span class="codefund-label">{{siteSettings.codefund_advertiser_label}}</span>
{{/if}}
<strong>{{adDetails.headline}}</strong> {{adDetails.description}}
<strong>{{adDetails.headline}}</strong> {{adDetails.body}}
</a>
<a href={{adDetails.poweredByLink}} class="codefund-powered-by" target="_blank" rel="noopener">
<a href={{adDetails.codefundUrl}} class="codefund-powered-by" target="_blank" rel="noopener">
ads via codefund.io
</a>
<img src="{{adDetails.impressionUrl}}" class="codefund-pixel">
</span>
7 changes: 4 additions & 3 deletions assets/javascripts/discourse/templates/components/codefund/topic-list-top.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
<span class="codefund-wrapper codefund-topic-list-top">
<a href="{{adDetails.link}}" class="codefund-text" target="_blank" rel="noopener">
<a href="{{adDetails.campaignUrl}}" class="codefund-text" target="_blank" rel="noopener">
{{#if siteSettings.codefund_display_advertiser_labels}}
<span class="codefund-label">{{siteSettings.codefund_advertiser_label}}</span>
{{/if}}
<strong>{{adDetails.headline}}</strong> {{adDetails.description}}
<strong>{{adDetails.headline}}</strong> {{adDetails.body}}
</a>
<a href={{adDetails.poweredByLink}} class="codefund-powered-by" target="_blank" rel="noopener">
<a href={{adDetails.codefundUrl}} class="codefund-powered-by" target="_blank" rel="noopener">
ads via codefund.io
</a>
<img src="{{adDetails.impressionUrl}}" class="codefund-pixel">
</span>
1 change: 0 additions & 1 deletion config/settings.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,6 @@ codefund_plugin:
codefund_property_id:
client: true
default: ''
regex: '^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$'
codefund_advertiser_label:
client: true
default: 'Advertiser'
Expand Down
10 changes: 10 additions & 0 deletions plugin.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,4 +175,14 @@
text-align: center;
}

.codefund-wrapper.codefund-topic-above-suggested {
clear: both;
}

.codefund-wrapper .codefund-pixel {
visibility: hidden;
height: 1px;
width: 1px;
}

CSS