DEV: use a proper object for tool definition

[SamSaffron]

This commit introduces a comprehensive refactoring of the AI tools system by adding a proper object-oriented interface for tool definitions. Instead of working with raw hash structures, tools are now represented by a proper ToolDefinition class with validation, parameter coercion, and schema generation capabilities.

Key changes:

• Add new ToolDefinition class with nested ParameterDefinition class

  • Strong validation for parameter types, names, and values
  • Type coercion for parameters (string, boolean, number, array, etc.)
  • JSON schema generation via parameters_json_schema method

• Refactor all dialect adapters to use the new class:

  • Replace direct hash manipulation with proper object methods
  • Simplify code by delegating schema generation to the ToolDefinition class
  • Consistent parameter handling across all LLM providers

• Improve the XmlToolProcessor to use tool definitions for parameter coercion

  • Properly handle type conversions for parameters in XML tool calls
  • Convert "true"/"false" strings to actual boolean values

• Change Ollama environment check to enable in both development and test

• Update tests to work with the new object-oriented interface

This change significantly improves code maintainability, type safety, and error handling while reducing duplicated parameter handling code across different LLM integrations.

[Copilot]

Pull Request Overview

This PR refactors the AI tools system to use an object‐oriented interface for tool definitions, improving type safety, maintainability, and consistency across LLM integrations. Key changes include:

• Introduction of a new ToolDefinition class with nested ParameterDefinition, including validation, parameter coercion, and JSON schema generation.
• Updates to dialect adapters and XML tool processing that replace raw hash manipulations with object methods.
• Revision of tests and endpoint handlers to work with the new object‐oriented interface.

Reviewed Changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
spec/lib/completions/tool_definition_spec.rb	Adds comprehensive tests for the new ToolDefinition and ParameterDefinition classes.
spec/lib/completions/endpoints/open_ai_spec.rb	Updates tests to reflect proper boolean parameter coercion and inclusion of new parameters.
spec/lib/completions/endpoints/nova_spec.rb	Adjusts JSON schema requirements, using description and required keys consistently.
spec/lib/completions/dialects/*	Updates multiple dialects (Ollama, Gemini, ChatGPT, Nova, Cohere, Claude) to translate tools using the new object interface.
lib/completions/xml_tool_processor.rb	Refactors tool call creation to utilize tool definitions for parameter coercion.
lib/completions/tool_definition.rb	Introduces the object-oriented implementation for tool definitions and parameter coercion logic.
lib/completions/prompt.rb	Modifies the tools setter to convert tool hashes to ToolDefinition instances.
lib/completions/endpoints/base.rb	Adjusts environment checks to enable the Ollama endpoint appropriately.