Skip to content
This repository was archived by the owner on Jul 22, 2025. It is now read-only.

DEV: cancel manager should bypass webmock #1350

Merged
merged 1 commit into from
May 20, 2025
Merged

DEV: cancel manager should bypass webmock #1350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions spec/lib/completions/cancel_manager_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
describe DiscourseAi::Completions::CancelManager do
fab!(:model) { Fabricate(:anthropic_model, name: "test-model") }

before { WebMock.allow_net_connect! }
Copy link
Contributor

@tgxworld tgxworld May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not following this as it means that we are allowing outgoing http connections in the test environment. Not sure if I am missing something here.

Copy link
Member Author

@SamSaffron SamSaffron May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, read downwards, it creates a web server see the current flake, there is a bug in webmock somewhere where it defines local incorrectly.


it "can stop monitoring for cancellation cleanly" do
cancel_manager = DiscourseAi::Completions::CancelManager.new
cancel_manager.start_monitor(delay: 100) { false }
Expand Down
Loading