This repository was archived by the owner on Jul 14, 2025. It is now read-only.
DEV: make specs regarding assign button more lenient #621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Member
Author
Done 👍
Yes, or that the specs are run with another plugins installed |
Contributor
|
Is there actual cross-contamination between plugin tests? are things enabled from other plugins/themes when running d-assign tests? |
Member
Author
Not in CI (AFAIK), but locally it might. |
Contributor
|
Locally shouldn't be an issue either - unless a test explicitly enables another plugin, its functionality should not be initialized. |
In discourse/discourse#30242, the topic footer buttons mobile dropdown can be replaced by the button if there's only one option. This fixes the spec that was clicking on the dropdown button before checking there was no assign option.
Member
Author
|
@cvx that makes things even easier then 😅 |
cvx
approved these changes
Dec 12, 2024
Contributor
cvx
left a comment
cvx
left a comment
There was a problem hiding this comment.
that makes things even easier then 😅
love it 😁
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in preparation of discourse/discourse#30242 which might make the assign button appear immediately (when it's the only available option) or behind the "..." dropdown.