FIX: Query name collision with multiple filters #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://meta.discourse.org/t/error-when-adding-3-or-4-filters-to-knowledge-explorer-plugin/167123/ If using more than two tags to filter, we'd run into an SQL alias collision on a few joins. Resolved by ensuring unique names are used across the query.
davidtaylorhq
approved these changes
Oct 14, 2020
Member
davidtaylorhq
left a comment
davidtaylorhq
left a comment
There was a problem hiding this comment.
Looks good 👍 would be cool to add a spec which demonstrates the issue as well, but that can come later if we need to get this merged ASAP
Contributor
Author
|
This was a duh moment for me - I thought I had added specs last night but apparently I didn't! 🤦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://meta.discourse.org/t/error-when-adding-3-or-4-filters-to-knowledge-explorer-plugin/167123/
If using more than two tags to filter, we'd run into an SQL alias
collision on a few joins. Resolved by ensuring unique names are used across the query.