FIX: Filters did not reset when visiting route #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a single Ember route, the query param filters did not properly reset when, for example, clicking the Knowledge Explorer link in the hamburger menu. This commit introduces a subroute where most of the logic takes place. This allows us to use the `refreshModel` option for query params on the route and remove the refresh controller action. Doing so also retains state of the search field instead of fully reloading the parent route.
featheredtoast
approved these changes
Nov 4, 2020
Member
featheredtoast
left a comment
featheredtoast
left a comment
There was a problem hiding this comment.
I went over some points I didn't understand, and it looks good to me.
We needed a subroute so that refresh doesn't take out the entire UI part.
I'd ideally like to avoid controller injection, but I do not see a clear way of doing that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a single Ember route, the query param filters did not
properly reset when, for example, clicking the Knowledge Explorer link
in the hamburger menu.
This commit introduces a subroute where most of the logic takes place.
This allows us to use the
refreshModeloption for query params on theroute and remove the refresh controller action. Doing so also retains
state of the search field instead of fully reloading the parent route.
Admittedly, mucking around with subroutes like this was a little foreign to me. I did inject the child controller into the parent so the search box would work. I'm not sure how stable/fragile this is, but it seemed like the best path forward.