Skip to content

DEV: Replace deprecated array methods in post-stream.js #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
megothss merged 2 commits into from
Dec 2, 2025
Merged

DEV: Replace deprecated array methods in post-stream.js #162

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb0a286
DEV: Replace deprecated `reads` with `dependentKeyCompat` in `post-st…
megothss Dec 1, 2025
0e8f8bd
Apply suggestions from code review
megothss Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions assets/javascripts/discourse/models/post-stream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { tracked } from "@glimmer/tracking";
import EmberObject from "@ember/object";
import { reads } from "@ember/object/computed";
import { dependentKeyCompat } from "@ember/object/compat";
import { ajax } from "discourse/lib/ajax";
import { addUniqueValuesToArray } from "discourse/lib/array-tools";
import { trackedArray } from "discourse/lib/tracked-tools";
Expand All @@ -12,14 +12,17 @@ import RestModel from "discourse/models/rest";
// component (in core as well) which expects a `UserStream` instance.

export default class PostStream extends RestModel {
@tracked loading = false;
@tracked itemsLoaded = 0;
@tracked canLoadMore = true;

@tracked itemsLoaded = 0;
@tracked loading = false;
@trackedArray content = [];

@reads("content.lastObject.created_at") lastPostCreatedAt;
@dependentKeyCompat
get lastPostCreatedAt() {
return this.content.at(-1)?.created_at;
}

@dependentKeyCompat
get noContent() {
return !this.loading && this.content.length === 0;
}
Expand All @@ -31,16 +34,13 @@ export default class PostStream extends RestModel {

this.loading = true;
const data = {};

if (this.lastPostCreatedAt) {
data.created_before = this.lastPostCreatedAt;
}

try {
const content = await ajax(`/follow/posts/${this.user.username}`, {
data,
});

const streamItems = content.posts.map((post) => {
return EmberObject.create({
title: post.topic.title,
Expand All @@ -60,12 +60,9 @@ export default class PostStream extends RestModel {
truncated: post.truncated,
});
});

const { hasMore } = content.extras;
addUniqueValuesToArray(this.content, streamItems);

this.itemsLoaded = this.content.length;
this.canLoadMore = hasMore;
this.canLoadMore = content.extras.has_more;
} finally {
this.loading = false;
}
Expand Down