Skip to content

DEV: Functional class to get the active selected translator #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025
Merged

DEV: Functional class to get the active selected translator #280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e35a9e0
DEV: Functional class to get the active selected translator
nattsw Apr 22, 2025
0b0dc80
zeitwerk
nattsw Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions app/controllers/discourse_translator/translator_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,10 @@ def translate
begin
title_json = {}
detected_lang, translation =
"DiscourseTranslator::Provider::#{SiteSetting.translator_provider}".constantize.translate(
post,
)
DiscourseTranslator::Provider::TranslatorProvider.get.translate(post)
if post.is_first_post?
_, title_translation =
"DiscourseTranslator::Provider::#{SiteSetting.translator_provider}".constantize.translate(
post.topic,
)
DiscourseTranslator::Provider::TranslatorProvider.get.translate(post.topic)
title_json = { title_translation: title_translation }
end
render json: { translation: translation, detected_lang: detected_lang }.merge(title_json),
Expand Down
2 changes: 1 addition & 1 deletion app/jobs/regular/detect_translatable_language.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ def execute(args)
translatable = args[:type].constantize.find_by(id: args[:translatable_id])
return if translatable.blank?
begin
translator = "DiscourseTranslator::Provider::#{SiteSetting.translator_provider}".constantize
translator = DiscourseTranslator::Provider::TranslatorProvider.get
translator.detect(translatable)
rescue ::DiscourseTranslator::Provider::ProblemCheckedTranslationError
# problem-checked translation errors gracefully
Expand Down
2 changes: 1 addition & 1 deletion app/jobs/regular/translate_translatable.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ def execute(args)

target_locales = SiteSetting.automatic_translation_target_languages.split("|")
target_locales.each do |target_locale|
"DiscourseTranslator::Provider::#{SiteSetting.translator_provider}".constantize.translate(
DiscourseTranslator::Provider::TranslatorProvider.get.translate(
translatable,
target_locale.to_sym,
)
Expand Down
3 changes: 1 addition & 2 deletions app/jobs/scheduled/automatic_translation_backfill.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,7 @@ def backfill_locales
end

def translator
@translator_klass ||=
"DiscourseTranslator::Provider::#{SiteSetting.translator_provider}".constantize
@translator_klass ||= DiscourseTranslator::Provider::TranslatorProvider.get
end

def translate_records(type, record_ids, target_locale)
Expand Down
11 changes: 11 additions & 0 deletions app/services/discourse_translator/provider/translator_provider.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# frozen_string_literal: true

module DiscourseTranslator
module Provider
class TranslatorProvider
def self.get
"DiscourseTranslator::Provider::#{SiteSetting.translator_provider}".constantize
end
end
end
end
Loading