FIX: Screened email list exposes IP addresses to moderators without IP-view permission#39875
Merged
tgxworld merged 2 commits intoMay 11, 2026
Merged
Conversation
…P-view permission
tgxworld
approved these changes
May 11, 2026
tgxworld
reviewed
May 11, 2026
| get "/admin/logs/screened_emails.json" | ||
|
|
||
| expect(response.status).to eq(200) | ||
| expect(response.parsed_body.first).not_to have_key("ip_address") |
Contributor
There was a problem hiding this comment.
I'm abit worried about this assertion because it isn't clear what response.parsed_body.first returns. It would be good to have an additional assertion above to validate the right email is being returned first before we assert that the email's payload doesn't include the ip_address key.
Member
Author
|
@patch-triage can you address tgxworlds comment please |
Contributor
|
Applied suggestions and committed the fix. Improve test assertion for screened email IP address visibility
|
Member
Author
|
@tgxworld it worked !!! look |
Contributor
nicee!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edge case where in an outlier case moderators can see ip addresses and should not be allowed to