DEV: Load all bundled plugins when running annotate:clean#39978
Merged
Conversation
Core models often pick up associations and columns from bundled plugins (e.g. `qa_vote_count` from `discourse-post-voting`, locale-detection indexes from `discourse-ai`), and the schema blocks at the bottom of `app/models/*.rb` should reflect those. `annotate:clean` now defaults `LOAD_PLUGINS` to the bundled plugin list (`script/list_bundled_plugins`) — the result is the same regardless of which extra plugins happen to be checked out under `plugins/`. Setting `LOAD_PLUGINS` explicitly still overrides. Includes the resulting one-off annotation regen.
davidtaylorhq
force-pushed
the
annotate-bundled-plugins
branch
from
fa23887 to
c21e02c
Compare
cvx
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core models often pick up associations and columns from bundled plugins (e.g.
qa_vote_countfromdiscourse-post-voting, locale-detection indexes fromdiscourse-ai), and the schema blocks at the bottom ofapp/models/*.rbshould reflect those.annotate:cleannow defaultsLOAD_PLUGINSto the bundled plugin list (script/list_bundled_plugins) — the result is the same regardless of which extra plugins happen to be checked out underplugins/. SettingLOAD_PLUGINSexplicitly still overrides.Includes the resulting one-off annotation regen.