add more SERVER_SIDE_ONLY routes; use pathname in matching#4660
Merged
eviltrout merged 1 commit intodiscourse:masterfrom Jan 17, 2017
Merged
add more SERVER_SIDE_ONLY routes; use pathname in matching#4660eviltrout merged 1 commit intodiscourse:masterfrom
eviltrout merged 1 commit intodiscourse:masterfrom
Conversation
|
Thanks @ryantm for your pull request 👍. By analyzing the blame information on this pull request, I identified @eviltrout and @ZogStriP to be potential reviewers. |
Contributor
|
Awesome, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #4645 here are some route fixes. I also changed it to match on the pathname instead of the full path, since it seems like that was what was intended anyway (judging by the "^/posts" regex).