fix: preserve full controller path #353
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
A recent change in this commit altered how the controller name is recorded.
Previously, metrics used
params["controller"], which returns the full namespaced path:After the commit, we switched to using
controller_instance.controller_name, which only returns the base controller name, stripping namespaces:Problem
This change breaks existing queries on our side that rely on the full path. For example:
no longer matches because
controller_nameonly provides"sessions"instead of"authentication/sessions".Solution
Use
controller_instance.controller_path, which preserves the previous behavior:This restores compatibility with existing queries.