Skip to content

SEC-2402: Updating version test matrix.#29

Merged
nchiasson-dgi merged 6 commits into
mainfrom
fix/test-matrix
Jan 21, 2026
Merged

SEC-2402: Updating version test matrix.#29
nchiasson-dgi merged 6 commits into
mainfrom
fix/test-matrix

Conversation

@nchiasson-dgi
Copy link
Copy Markdown
Collaborator

@nchiasson-dgi nchiasson-dgi commented Jan 20, 2026

Summary by CodeRabbit

  • Chores
    • Updated CI testing matrix: removed outdated Drupal combinations (including 10.4 and 11.1), added Drupal 10.5, 10.6 and 11.2 across multiple PHP versions, and introduced several experimental/leniency-configured test entries.

✏️ Tip: You can customize this high-level summary in your review settings.

@nchiasson-dgi nchiasson-dgi added the minor Added functionality that is backwards compatible. label Jan 20, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jan 20, 2026

📝 Walkthrough

Walkthrough

Updated the GitHub Actions phpunit workflow matrix: removed Drupal 10.4 and 11.1 entries, replaced a 10.3 include with 10.5, added/expanded Drupal 10.6 and 11.2 combinations across PHP 8.3–8.5, and marked several entries as experimental with adjusted do-leniency flags.

Changes

Cohort / File(s) Summary
GitHub Actions workflow
.github/workflows/phpunit.yml
Edited matrix includes: removed drupal-version: '10.4' and 11.1; replaced a 10.3 include with 10.5; added/expanded 10.6 and 11.2 combinations for PHP 8.38.5; annotated several entries as experimental and adjusted do-leniency flags.

Sequence Diagram(s)

(omitted)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

patch

Suggested reviewers

  • jordandukart

Poem

🐰 I hopped through YAML rows tonight,
Swapping versions left and right.
Experimental flags I tuck,
So tests may try their luck. 🌱

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: updating the version test matrix in the GitHub Actions workflow file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • JIRA integration encountered authorization issues. Please disconnect and reconnect the integration in the CodeRabbit UI.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nchiasson-dgi nchiasson-dgi changed the title Updating version test matrix. SEC-2402: Updating version test matrix. Jan 21, 2026
@nchiasson-dgi nchiasson-dgi marked this pull request as ready for review January 21, 2026 12:34
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @.github/workflows/phpunit.yml:
- Around line 49-53: The matrix entry that pairs drupal-version: '10.6' with
php-version: '8.5' (the block containing drupal-version, php-version,
experimental, do-leniency) must be removed or replaced because the Docker image
drupal:10.6-php8.5 does not exist; either delete that matrix row entirely or
change it to a valid combination (e.g., set php-version to '8.4' for
drupal-version '10.6' or change drupal-version to '11.2' if you need php-version
'8.5') and keep the experimental/do-leniency flags as needed.

Comment thread .github/workflows/phpunit.yml Outdated
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/phpunit.yml (1)

34-48: Remove the drupal:10.6-php8.2 configuration entry from the workflow.

The drupal:10.6-php8.2 Docker image does not exist on Docker Hub. Only 10.6-php8.3 and 10.6-php8.4 are available. This configuration will cause workflow failures. Lines 34-39 should be removed to keep only the working 8.3 and 8.4 variants.

@nchiasson-dgi nchiasson-dgi merged commit fc86c69 into main Jan 21, 2026
2 checks passed
@nchiasson-dgi nchiasson-dgi deleted the fix/test-matrix branch January 21, 2026 14:45
@github-actions
Copy link
Copy Markdown

Tag generated by PR: v1.5.0

Comment on lines +30 to 31
- drupal-version: '10.5'
php-version: '8.2'
Copy link
Copy Markdown
Contributor

@adam-vessey adam-vessey Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be exploding?: https://github.com/discoverygarden/dgi_migrate/actions/runs/21225355647/job/61070755252?pr=178

[...]
Starting job container
  /usr/bin/docker pull drupal:10.5-php8.2
  Error response from daemon: manifest for drupal:10.5-php8.2 not found: manifest unknown: manifest unknown
[...]

Copy link
Copy Markdown
Contributor

@adam-vessey adam-vessey Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went ahead and updated things: #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor Added functionality that is backwards compatible.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants