SEC-2402: Updating version test matrix.#29
Conversation
📝 WalkthroughWalkthroughUpdated the GitHub Actions phpunit workflow matrix: removed Drupal 10.4 and 11.1 entries, replaced a 10.3 include with 10.5, added/expanded Drupal 10.6 and 11.2 combinations across PHP 8.3–8.5, and marked several entries as experimental with adjusted Changes
Sequence Diagram(s)(omitted) Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/workflows/phpunit.yml:
- Around line 49-53: The matrix entry that pairs drupal-version: '10.6' with
php-version: '8.5' (the block containing drupal-version, php-version,
experimental, do-leniency) must be removed or replaced because the Docker image
drupal:10.6-php8.5 does not exist; either delete that matrix row entirely or
change it to a valid combination (e.g., set php-version to '8.4' for
drupal-version '10.6' or change drupal-version to '11.2' if you need php-version
'8.5') and keep the experimental/do-leniency flags as needed.
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/phpunit.yml (1)
34-48: Remove thedrupal:10.6-php8.2configuration entry from the workflow.The
drupal:10.6-php8.2Docker image does not exist on Docker Hub. Only10.6-php8.3and10.6-php8.4are available. This configuration will cause workflow failures. Lines 34-39 should be removed to keep only the working 8.3 and 8.4 variants.
|
Tag generated by PR: v1.5.0 |
| - drupal-version: '10.5' | ||
| php-version: '8.2' |
There was a problem hiding this comment.
This appears to be exploding?: https://github.com/discoverygarden/dgi_migrate/actions/runs/21225355647/job/61070755252?pr=178
[...]
Starting job container
/usr/bin/docker pull drupal:10.5-php8.2
Error response from daemon: manifest for drupal:10.5-php8.2 not found: manifest unknown: manifest unknown
[...]
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.