Code style suggestions#167
Closed
romfrolov wants to merge 4 commits intodisease-sh:masterfrom
romfrolov:code-style-suggestions
Closed
Code style suggestions#167romfrolov wants to merge 4 commits intodisease-sh:masterfrom romfrolov:code-style-suggestions
romfrolov wants to merge 4 commits intodisease-sh:masterfrom
romfrolov:code-style-suggestions
Conversation
romfrolov
commented
Mar 24, 2020
Comment on lines
+38
to
41
| // REVIEW | ||
| // parsedCases.pop() | ||
| // parsedDeaths.pop() | ||
| // recParsed.pop() |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| // REVIEW | |
| // parsedCases.pop() | |
| // parsedDeaths.pop() | |
| // recParsed.pop() |
We should either remove these lines or add some meaningful comment about why these lines should remain commented out.
ebwinters
reviewed
Mar 25, 2020
Contributor
Author
|
@ebwinters I returned the previous values to avoid conflicts and keep PRs independent. |
|
not required and is conflicting with some changes ;( |
ghost
closed this
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
varCloses #164.
Closes #166.