Conversation
jws-1
force-pushed
the
overview-tab-layers
branch
from
1f0187b to
55b8fc7
Compare
…ture of the ModuleLayersModel...
trisyoungs
approved these changes
Sep 12, 2023
Member
trisyoungs
left a comment
trisyoungs
left a comment
There was a problem hiding this comment.
Apart from the ugliness this is looking pretty good!
| dissolveModel_ = dissolveModel; | ||
| } | ||
|
|
||
| QImage DissolveModelImageProvider::requestImage(const QString &id, QSize *size, const QSize &requestedSize) |
Member
There was a problem hiding this comment.
Hmm. Perhaps a contender for my new most-despised Qt override!
src/gui/models/moduleLayersModel.cpp
Outdated
Comment on lines
+51
to
+54
| return QString::fromStdString(std::string(data->name())); | ||
| case (Qt::UserRole): | ||
| return QVariant::fromValue(rawData(index)); | ||
| return QVariant::fromValue(data); | ||
| case (Qt::UserRole + 1): |
Member
There was a problem hiding this comment.
I think we definitely need a custom enum using Qt::UserRole as the base here.
Member
Author
There was a problem hiding this comment.
Ah yep, I meant to do that but forgot to come back!
Co-authored-by: Tristan Youngs <tristan.youngs@stfc.ac.uk>
rprospero
pushed a commit
that referenced
this pull request
Mar 11, 2024
Co-authored-by: Tristan Youngs <tristan.youngs@stfc.ac.uk>
rprospero
pushed a commit
that referenced
this pull request
Apr 8, 2024
Co-authored-by: Tristan Youngs <tristan.youngs@stfc.ac.uk>
rprospero
pushed a commit
that referenced
this pull request
Apr 9, 2024
Co-authored-by: Tristan Youngs <tristan.youngs@stfc.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small PR adds
ModuleLayersto theOverviewTab, as well as displaying (but not offering means to edit) their correspondingModules. Future work (see #1652) will make this view more aesthetically pleasing (for example, ensuring thatNodesare sized to fit their contents), as well as providing means to editModuleLayersand control theirModules. Furthermore, theModuleListViewcurrently cannot be navigated, but this will be dealt with in a future PR along with the previously described visual improvements.