feat: Node data serialisation #2242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trisyoungs
force-pushed
the
dissolve2/node-data-serialisation
branch
from
ebffb7b to
b287bfe
Compare
trisyoungs
force-pushed
the
dissolve2/node-data-serialisation
branch
from
992b551 to
068dc51
Compare
trisyoungs
force-pushed
the
dissolve2/node-data-serialisation
branch
from
068dc51 to
5876239
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 93eb6c9 | Previous: fe432fc | Ratio |
|---|---|---|---|
BM_Box_MinimumImage<CubicBox> |
46.67427107273266 ns/iter |
14.720236046648049 ns/iter |
3.17 |
BM_Box_MinimumVector<CubicBox> |
31.69142482181134 ns/iter |
10.805559247637298 ns/iter |
2.93 |
BM_Box_MinimumImage<OrthorhombicBox> |
43.04734980470494 ns/iter |
16.09258159686038 ns/iter |
2.67 |
BM_Box_MinimumVector<OrthorhombicBox> |
29.531711220758062 ns/iter |
10.720444593028015 ns/iter |
2.75 |
BM_Box_MinimumImage<MonoclinicAlphaBox> |
34.5154789667622 ns/iter |
11.894333076758135 ns/iter |
2.90 |
BM_Box_MinimumVector<MonoclinicAlphaBox> |
22.076089200374213 ns/iter |
8.047862156503925 ns/iter |
2.74 |
BM_Box_MinimumImage<TriclinicBox> |
37.90982969156062 ns/iter |
16.352504316387808 ns/iter |
2.32 |
BM_Box_MinimumVector<TriclinicBox> |
24.073042888658648 ns/iter |
11.175347426982341 ns/iter |
2.15 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @disorderedmaterials/dissolve-devs
trisyoungs
force-pushed
the
dissolve2/node-data-serialisation
branch
3 times, most recently
from
1f4d938 to
310939a
Compare
trisyoungs
force-pushed
the
dissolve2/node-data-serialisation
branch
from
01d38d9 to
0a3c8c5
Compare
This was referenced Oct 15, 2025
trisyoungs
force-pushed
the
dissolve2/node-data-serialisation
branch
from
0a3c8c5 to
a904d94
Compare
trisyoungs
changed the base branch from
develop2
to
dissolve2/class-serialisers
trisyoungs
force-pushed
the
dissolve2/node-data-serialisation
branch
from
a904d94 to
9a60a3f
Compare
trisyoungs
force-pushed
the
dissolve2/node-data-serialisation
branch
from
9a60a3f to
91c8cd1
Compare
rprospero
approved these changes
Oct 17, 2025
Contributor
rprospero
left a comment
rprospero
left a comment
There was a problem hiding this comment.
One minor suggestion, but things otherwise look good.
rprospero
pushed a commit
that referenced
this pull request
Feb 4, 2026
Co-authored-by: Tristan Youngs <trisyoungs@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements serialisation of restart file data for the current complement of nodes, building off #2203.
TODO
std::optionalneeds to emplace the data first.Template args toMoved to Refactor is_instance_of_v #2260is_instance_of<>are reversed c.f. comparable stdlib functionslongs for bin counts)Historyserialisation test, especially with custom initialiser function.Move simple test functions out ofMoved to Dissolve2DoDissolveSystemTest