refactor: Forcefield tidy up#2455
Merged
Merged
Conversation
… - gives more flexibility in the long term.
rprospero
approved these changes
May 27, 2026
Contributor
rprospero
left a comment
rprospero
left a comment
There was a problem hiding this comment.
This is also a nice step toward eventually getting rid of OptionalReferenceWrapper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR wages code war on the
Forcefieldclass with the intent to streamline it ahead of updating the existingForcefieldNodeto reproduce the behaviour of theAddForcefieldDialog/ wizard, a UI element which is not being directly in the Dissolve2 GUI. To that end, this PR removes it.