expose host pprof on http endpoint #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Achille Roussel <achille.roussel@gmail.com>
Signed-off-by: Achille Roussel <achille.roussel@gmail.com>
Signed-off-by: Achille Roussel <achille.roussel@gmail.com>
Signed-off-by: Achille Roussel <achille.roussel@gmail.com>
achille-roussel
force-pushed
the
host-pprof
branch
from
899ef5b to
328a9eb
Compare
Signed-off-by: Achille Roussel <achille.roussel@gmail.com>
pelletier
approved these changes
May 9, 2023
|
|
||
| func indexTmplExecute(w io.Writer, guest, host []profileEntry) error { | ||
| var b bytes.Buffer | ||
| b.WriteString(`<html> |
There was a problem hiding this comment.
Is there any reason why you didn't want to use html/template for this? Feels like it would be easier to read and maintain. :)
There was a problem hiding this comment.
The only reason is I copied the code from net/http/pprof :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.