Allow wzprof to run without dwarf #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression from #46. By turning this error into a warning, we allow wzprof to be used on modules that don't have DWARF, such as those produced by golang/go.
chriso
approved these changes
May 18, 2023
| symbols, err := wzprof.BuildDwarfSymbolizer(compiledModule) | ||
| if err != nil { | ||
| return fmt.Errorf("symbolizing wasm module: %w", err) | ||
| symbols = nil |
There was a problem hiding this comment.
Isn't this going to crash when we generate the profile if the symbolizer is nil?
There was a problem hiding this comment.
Ah nevermind we have a check there https://github.com/stealthrocket/wzprof/blob/main/wzprof.go#L83-L86
What do you think about removing the nil check an instead using a no-op implementation of the interface? nil as a valid value seems like asking for trouble.
There was a problem hiding this comment.
Yeah I thought about it, but figured I'll revamp all this when I'll add pclntab support and need to do some kind of symbolizer selection.
achille-roussel
approved these changes
May 18, 2023
|
Looks good. It might be better to say "dwarf not available" instead of the first warning, but hey, it works! $ GOOS=wasip1 GOARCH=wasm gotip build -o math.wasm math.go
$ wzprof -sample 1 -memprofile /tmp/profile math.wasm
2023/05/19 07:02:02 warning: symbolizing wasm module: dwarf: decoding dwarf section info at offset 0x0: too short
3
$ go tool pprof -http :4000 /tmp/profile
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from #46. By turning this error into a warning, we allow wzprof to be used on modules that don't have DWARF, such as those produced by golang/go, and still provide meaningful results (though laking line-level profiles, and source code display).
cc @codefromthecrypt