add snapshot list capability#1
Merged
disperate merged 3 commits intojulian/add-snapshot-create-delete-capabilityfrom Feb 16, 2026
Merged
add snapshot list capability#1disperate merged 3 commits intojulian/add-snapshot-create-delete-capabilityfrom
disperate merged 3 commits intojulian/add-snapshot-create-delete-capabilityfrom
Conversation
mweibel
approved these changes
Feb 13, 2026
Comment on lines
+857
to
+859
| sort.Slice(filtered, func(i, j int) bool { | ||
| return filtered[i].UUID < filtered[j].UUID | ||
| }) |
There was a problem hiding this comment.
(thinking out loud) - I thought first if we should rather use sort.SliceStable or even the slices.SortStableFunc together with strings.Compare because of the documentation that it's possibly faster and more ergonomic to use. But most likely the slice size is rather small and also UUIDs are guaranteed to not be the same (so Stable is not necessary in this case).
Long story short - I think it's fine to keep it like this.
disperate
merged commit 7f9d04e
into
julian/add-snapshot-create-delete-capability
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.