Ignore extra disk-stats array if present. #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some versions of fio produce an extra disk-stats array. This change makes the postprocess script ignore the extra array if present.
ndokos
force-pushed
the
wip-fio-postprocess
branch
from
3ca21f4 to
4eba91b
Compare
ndokos
added a commit
that referenced
this pull request
Nov 24, 2015
Ignore extra disk-stats array if present.
portante
pushed a commit
that referenced
this pull request
Oct 16, 2021
Starting with the 30 September 2021 build ([#110](http://jenkins.perf.lab.eng.bos.redhat.com/job/pbench-ci-multi/job/main/110/)), Mr. Jenkins is no longer finding the Cobertura coverage report which the PyTest run creates. (This corresponds to Git hash a53ddeb, which I believe is PR #2349.) What's more, while the file seems to be created properly by the PyTest run in the container, when the `post` section of the pipeline is executed, the file is gone! The previously-merged PR #2424 made changes which are relevant to this functionality. (Its build, [#109](http://jenkins.perf.lab.eng.bos.redhat.com/job/pbench-ci-multi/job/main/109/), _failed_ due to non-deterministic behavior of one of the tests; otherwise, I believe it would have shown this behavior as well.) The answer turns out to be that, while the file is created inside the container, the execution of the `post` section is outside the container, and so the file systems are different, and the file exists but is not where we expect to find it. Prior to PR #2424, `jenkins/run` was mapping the Jenkins temporary directory into the container as `/tmp`, which allowed the `post` section to find the file. PR #2424 simplified the invocation of the container, and this detail was lost. This commit changes the location of the coverage report to place it back into a mapped file system, and it puts it in a location which is easily accessible both inside and outside the container...and now things work again. (And, it replaces the slightly confusing comment in the `Pipeline.gy` file with a new slightly less confusing comment.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some versions of fio produce an extra disk-stats array.
This change makes the postprocess script ignore the extra array
if present.