Decompose pbench-move-results into "make" and "copy" components #1289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
portante
force-pushed
the
enh-move-results
branch
2 times, most recently
from
8a24c55 to
e19698b
Compare
ndokos
requested changes
Aug 9, 2019
portante
force-pushed
the
enh-move-results
branch
from
e19698b to
c941cf0
Compare
We now have separate commands for "making a result tar ball" and for "moving" a result tar ball", `pbench-make|copy-result-tb`. By breaking this command up into its loop components, we can use those components for other purposes, e.g. allowing a caller to invoke "make" and "copy" in different environments. One such intended use is to drive server side testing where an existing set of tar balls can be "copied" repeatedly to verify a staging environment. We also enhance `pbench-move-results` to verify internal `rm` and `touch` operations so that it can error out early without cascading errors being created.
portante
force-pushed
the
enh-move-results
branch
from
c941cf0 to
df85bdb
Compare
ndokos
approved these changes
Aug 9, 2019
portante
changed the title
portante
added a commit
to portante/pbench
that referenced
this pull request
Sep 26, 2019
As of PR distributed-system-analysis#1289, specifically line [177](https://github.com/distributed-system-analysis/pbench/pull/1289/files?file-filters%5B%5D=No+extension#diff-d7362c40121612a2669161b65d94590aR177), the any invocation of `pbench-move|copy-results` that did not use both `--user` and `--prefix` unexpected always received an unwanted "`user`" and sometimes got the wrong "`--prefix`". * If you did not use either `--user` or `--prefix`, then your "`user`" was being set to "`--prefix`" * If you used only `--user`, then your "`user`" was correct, but your "`prefix`" was being set to "`--xy-singled-threaded`" * If you used only `--prefix`, then your "`user`" was being set to "`--prefix`", and your "`prefix`" was being ignored If you used both `--user` and `--prefix` then your "`user`" and "`prefix`" were being set as expected. This PR correctly the incorrect invocation of `pbench-make-result-tb` from `pbench-move-results`.
portante
added a commit
to portante/pbench
that referenced
this pull request
Sep 26, 2019
As of PR distributed-system-analysis#1289, specifically line [177](https://github.com/distributed-system-analysis/pbench/pull/1289/files?file-filters%5B%5D=No+extension#diff-d7362c40121612a2669161b65d94590aR177), the any invocation of `pbench-move|copy-results` that did not use both `--user` and `--prefix` unexpected always received an unwanted "`user`" and sometimes got the wrong "`--prefix`". * If you did not use either `--user` or `--prefix`, then your "`user`" was being set to "`--prefix`" * If you used only `--user`, then your "`user`" was correct, but your "`prefix`" was being set to "`--xy-singled-threaded`" * If you used only `--prefix`, then your "`user`" was being set to "`--prefix`", and your "`prefix`" was being ignored If you used both `--user` and `--prefix` then your "`user`" and "`prefix`" were being set as expected. This PR corrects the incorrect invocation of `pbench-make-result-tb` from `pbench-move-results`.
portante
added a commit
to portante/pbench
that referenced
this pull request
Sep 26, 2019
As of PR distributed-system-analysis#1289, specifically line [177](https://github.com/distributed-system-analysis/pbench/pull/1289/files?file-filters%5B%5D=No+extension#diff-d7362c40121612a2669161b65d94590aR177), then any invocation of `pbench-move|copy-results` that did not use both `--user` and `--prefix` always received an unwanted "`user`", and sometimes got the wrong "`--prefix`". * If you did not use either `--user` or `--prefix`, then your "`user`" was being set to "`--prefix`" * If you used only `--user`, then your "`user`" was correct, but your "`prefix`" was being set to "`--xy-singled-threaded`" * If you used only `--prefix`, then your "`user`" was being set to "`--prefix`", and your "`prefix`" was being ignored If you used both `--user` and `--prefix` then your "`user`" and "`prefix`" were being set as expected. This PR corrects the invocation of `pbench-make-result-tb` from `pbench-move-results`.
portante
added a commit
to portante/pbench
that referenced
this pull request
Sep 26, 2019
As of PR distributed-system-analysis#1289, specifically line [177](https://github.com/distributed-system-analysis/pbench/pull/1289/files?file-filters%5B%5D=No+extension#diff-d7362c40121612a2669161b65d94590aR177), any invocation of `pbench-move|copy-results` that did not use both `--user` and `--prefix` always received an unwanted "`user`", and sometimes got the wrong "`--prefix`". * If you did not use either `--user` or `--prefix`, then your "`user`" was being set to "`--prefix`" * If you used only `--user`, then your "`user`" was correct, but your "`prefix`" was being set to "`--xy-singled-threaded`" * If you used only `--prefix`, then your "`user`" was being set to "`--prefix`", and your "`prefix`" was being ignored If you used both `--user` and `--prefix` then your "`user`" and "`prefix`" were being set as expected. This PR corrects the invocation of `pbench-make-result-tb` from `pbench-move-results`.
portante
added a commit
to portante/pbench
that referenced
this pull request
Sep 27, 2019
As of PR distributed-system-analysis#1289, specifically line [177](https://github.com/distributed-system-analysis/pbench/pull/1289/files?file-filters%5B%5D=No+extension#diff-d7362c40121612a2669161b65d94590aR177), any invocation of `pbench-move|copy-results` that did not use both `--user` and `--prefix` always received an unwanted "`user`", and sometimes got the wrong "`--prefix`". * If you did not use either `--user` or `--prefix`, then your "`user`" was being set to "`--prefix`" * If you used only `--user`, then your "`user`" was correct, but your "`prefix`" was being set to "`--xy-singled-threaded`" * If you used only `--prefix`, then your "`user`" was being set to "`--prefix`", and your "`prefix`" was being ignored If you used both `--user` and `--prefix` then your "`user`" and "`prefix`" were being set as expected. This PR corrects the invocation of `pbench-make-result-tb` from `pbench-move-results`.
portante
added a commit
to portante/pbench
that referenced
this pull request
Sep 27, 2019
As of PR distributed-system-analysis#1289, specifically line [177](https://github.com/distributed-system-analysis/pbench/pull/1289/files?file-filters%5B%5D=No+extension#diff-d7362c40121612a2669161b65d94590aR177), any invocation of `pbench-move|copy-results` that did not use both `--user` and `--prefix` always received an unwanted "`user`", and sometimes got the wrong "`--prefix`". * If you did not use either `--user` or `--prefix`, then your "`user`" was being set to "`--prefix`" * If you used only `--user`, then your "`user`" was correct, but your "`prefix`" was being set to "`--xy-singled-threaded`" * If you used only `--prefix`, then your "`user`" was being set to "`--prefix`", and your "`prefix`" was being ignored If you used both `--user` and `--prefix` then your "`user`" and "`prefix`" were being set as expected. This PR corrects the invocation of `pbench-make-result-tb` from `pbench-move-results`.
portante
added a commit
to portante/pbench
that referenced
this pull request
Sep 27, 2019
As of PR distributed-system-analysis#1289, specifically line [177](https://github.com/distributed-system-analysis/pbench/pull/1289/files?file-filters%5B%5D=No+extension#diff-d7362c40121612a2669161b65d94590aR177), any invocation of `pbench-move|copy-results` that did not use both `--user` and `--prefix` always received an unwanted "`user`", and sometimes got the wrong "`--prefix`". * If you did not use either `--user` or `--prefix`, then your "`user`" was being set to "`--prefix`" * If you used only `--user`, then your "`user`" was correct, but your "`prefix`" was being set to "`--xy-singled-threaded`" * If you used only `--prefix`, then your "`user`" was being set to "`--prefix`", and your "`prefix`" was being ignored If you used both `--user` and `--prefix` then your "`user`" and "`prefix`" were being set as expected. This PR corrects the invocation of `pbench-make-result-tb` from `pbench-move-results`, and ensures that empty arguments for `--user` and `--prefix` are properly handled.
portante
added a commit
to portante/pbench
that referenced
this pull request
Sep 27, 2019
As of PR distributed-system-analysis#1289, specifically line [177](https://github.com/distributed-system-analysis/pbench/pull/1289/files?file-filters%5B%5D=No+extension#diff-d7362c40121612a2669161b65d94590aR177), any invocation of `pbench-move|copy-results` that did not use both `--user` and `--prefix` always received an unwanted "`user`", and sometimes got the wrong "`--prefix`". * If you did not use either `--user` or `--prefix`, then your "`user`" was being set to "`--prefix`" * If you used only `--user`, then your "`user`" was correct, but your "`prefix`" was being set to "`--xy-singled-threaded`" * If you used only `--prefix`, then your "`user`" was being set to "`--prefix`", and your "`prefix`" was being ignored If you used both `--user` and `--prefix` then your "`user`" and "`prefix`" were being set as expected. This PR corrects the invocation of `pbench-make-result-tb` from `pbench-move-results`, and ensures that empty arguments for `--user` and `--prefix` are properly handled.
portante
added a commit
to portante/pbench
that referenced
this pull request
Sep 27, 2019
As of PR distributed-system-analysis#1289, specifically line [177](https://github.com/distributed-system-analysis/pbench/pull/1289/files?file-filters%5B%5D=No+extension#diff-d7362c40121612a2669161b65d94590aR177), any invocation of `pbench-move|copy-results` that did not use both `--user` and `--prefix` always received an unwanted "`user`", and sometimes got the wrong "`--prefix`". * If you did not use either `--user` or `--prefix`, then your "`user`" was being set to "`--prefix`" * If you used only `--user`, then your "`user`" was correct, but your "`prefix`" was being set to "`--xy-singled-threaded`" * If you used only `--prefix`, then your "`user`" was being set to "`--prefix`", and your "`prefix`" was being ignored If you used both `--user` and `--prefix` then your "`user`" and "`prefix`" were being set as expected. This PR corrects the invocation of `pbench-make-result-tb` from `pbench-move-results`, and ensures that empty arguments for `--user` and `--prefix` are properly handled.
portante
added a commit
that referenced
this pull request
Sep 27, 2019
As of PR #1289, specifically line [177](https://github.com/distributed-system-analysis/pbench/pull/1289/files?file-filters%5B%5D=No+extension#diff-d7362c40121612a2669161b65d94590aR177), any invocation of `pbench-move|copy-results` that did not use both `--user` and `--prefix` always received an unwanted "`user`", and sometimes got the wrong "`--prefix`". * If you did not use either `--user` or `--prefix`, then your "`user`" was being set to "`--prefix`" * If you used only `--user`, then your "`user`" was correct, but your "`prefix`" was being set to "`--xy-singled-threaded`" * If you used only `--prefix`, then your "`user`" was being set to "`--prefix`", and your "`prefix`" was being ignored If you used both `--user` and `--prefix` then your "`user`" and "`prefix`" were being set as expected. This PR corrects the invocation of `pbench-make-result-tb` from `pbench-move-results`, and ensures that empty arguments for `--user` and `--prefix` are properly handled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now have separate commands for "making a result tar ball" and for "copying" a result tar ball",
pbench-make|copy-result-tb. By breaking this command up into its loop components, we can use those components for other purposes, e.g. allowing a caller to invoke "make" and "copy" in different environments.One such intended use is to drive server side testing where an existing set of tar balls can be "copied" repeatedly to verify a staging environment.