Short-term fix for missing pb-m-r user/prefix args #1369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
portante
force-pushed
the
fix-mv-res
branch
from
82bed20 to
862a435
Compare
ndokos
requested changes
Sep 27, 2019
Member
ndokos
left a comment
ndokos
left a comment
There was a problem hiding this comment.
This may be right, but if so, I am really confused. Maybe we can discuss?
portante
force-pushed
the
fix-mv-res
branch
from
862a435 to
1d00f0d
Compare
portante
force-pushed
the
fix-mv-res
branch
from
1d00f0d to
e4823a3
Compare
ndokos
approved these changes
Sep 27, 2019
portante
force-pushed
the
fix-mv-res
branch
2 times, most recently
from
92052c4 to
7b9b669
Compare
As of PR distributed-system-analysis#1289, specifically line [177](https://github.com/distributed-system-analysis/pbench/pull/1289/files?file-filters%5B%5D=No+extension#diff-d7362c40121612a2669161b65d94590aR177), any invocation of `pbench-move|copy-results` that did not use both `--user` and `--prefix` always received an unwanted "`user`", and sometimes got the wrong "`--prefix`". * If you did not use either `--user` or `--prefix`, then your "`user`" was being set to "`--prefix`" * If you used only `--user`, then your "`user`" was correct, but your "`prefix`" was being set to "`--xy-singled-threaded`" * If you used only `--prefix`, then your "`user`" was being set to "`--prefix`", and your "`prefix`" was being ignored If you used both `--user` and `--prefix` then your "`user`" and "`prefix`" were being set as expected. This PR corrects the invocation of `pbench-make-result-tb` from `pbench-move-results`, and ensures that empty arguments for `--user` and `--prefix` are properly handled.
portante
force-pushed
the
fix-mv-res
branch
from
7b9b669 to
e691b0e
Compare
ndokos
approved these changes
Sep 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of PR #1289, specifically line 177, any invocation of
pbench-move|copy-resultsthat did not use both--userand--prefixalways received an unwanted "user", and sometimes got the wrong "--prefix".If you did not use either
--useror--prefix, then your "user" was being set to "--prefix"If you used only
--user, then your "user" was correct, but your "prefix" was being set to "--xy-singled-threaded"If you used only
--prefix, then your "user" was being set to "--prefix", and your "prefix" was being ignoredIf you used both
--userand--prefixthen your "user" and "prefix" were being set as expected.This PR corrects the invocation of
pbench-make-result-tbfrompbench-move-results.