Skip to content

Conversation

@ndokos
Copy link
Member

@ndokos ndokos commented Dec 22, 2015

All the util scripts now have a prefix of pbench-.

#64

@ndokos ndokos self-assigned this Dec 22, 2015
@ndokos ndokos force-pushed the wip-rename-util-scripts branch from b8a0f12 to 13b98f2 Compare January 26, 2016 23:09
@ndokos
Copy link
Member Author

ndokos commented Jan 26, 2016

We can add symlinks from the old names to the new names for backwards compatibility - and we can do that in the RPM rather than adding them to the repo. After a suitable period,
and with enough warning, we can get rid of them for a future release. Thoughts?
If that's acceptable, we can include this PR in the next release.

@atheurer
Copy link
Contributor

Not sure how I feel about symlinks. I would expect that people would just continue to use the old names, unless there's a huge warning every time they use the old name.

@portante
Copy link
Member

In this case, I am not in favor of backward compatibility. If they need that, I would suggest that use the existing release. This is a sufficiently large problem for other reasons that I do not think trying to maintain backward compatibility is worth it here.

@ndokos
Copy link
Member Author

ndokos commented Jan 27, 2016

The travis build is borked - I'm looking into what needs to be done to fix it:

$ sudo pip3 install configtools elasticsearch

/usr/local/lib/python3.2/dist-packages/pip-8.0.2-py3.2.egg/pip/_vendor/pkg_resources/init.py:87: UserWarning: Support for Python 3.0-3.2 has been dropped. Future versions will fail here.

warnings.warn(msg)

Traceback (most recent call last):

File "/usr/local/bin/pip3", line 9, in

load_entry_point('pip==8.0.2', 'console_scripts', 'pip3')()

File "/usr/lib/python3/dist-packages/pkg_resources.py", line 337, in load_entry_point

return get_distribution(dist).load_entry_point(group, name)

File "/usr/lib/python3/dist-packages/pkg_resources.py", line 2280, in load_entry_point

return ep.load()

File "/usr/lib/python3/dist-packages/pkg_resources.py", line 1990, in load

entry = __import__(self.module_name, globals(),globals(), ['__name__'])

File "/usr/local/lib/python3.2/dist-packages/pip-8.0.2-py3.2.egg/pip/init.py", line 15, in

from pip.vcs import git, mercurial, subversion, bazaar  # noqa

File "/usr/local/lib/python3.2/dist-packages/pip-8.0.2-py3.2.egg/pip/vcs/mercurial.py", line 9, in

from pip.download import path_to_url

File "/usr/local/lib/python3.2/dist-packages/pip-8.0.2-py3.2.egg/pip/download.py", line 35, in

from pip.utils.ui import DownloadProgressBar, DownloadProgressSpinner

File "/usr/local/lib/python3.2/dist-packages/pip-8.0.2-py3.2.egg/pip/utils/ui.py", line 15, in

from pip._vendor.progress.bar import Bar, IncrementalBar

File "/usr/local/lib/python3.2/dist-packages/pip-8.0.2-py3.2.egg/pip/_vendor/progress/bar.py", line 48

empty_fill = u'∙'

                  ^

SyntaxError: invalid syntax

@ndokos
Copy link
Member Author

ndokos commented Jan 27, 2016

Re: backward compatibility - we could add a script that would take an old name, issue a big fat warning and call the new name, as Andrew suggests. If we don't provide BC, we are basically saying that if you want the new release, you have to go modify your scripts first. It seems to me that the transition would be harder that way.

@atheurer
Copy link
Contributor

As long as we have the warning, I think that will be ok.
We will release another version next month anyway, and hopefully that one removes the older names.

@ndokos ndokos force-pushed the wip-rename-util-scripts branch 7 times, most recently from e15e881 to 7ff4534 Compare February 3, 2016 20:32
All the util scripts now have a prefix of pbench-.

Move non-pbench scripts to contrib/ subdirectory.

contrib/ is not added to the PATH so there will be no
collision. If users want to use one or more of these,
they will need to call them by full pathname or add
contrib/ to their PATH.

Add a backward-compatibility wrapper temporarily.

We maintain compatibility with the old util-scripts names
*for one release only*. The old names will be symlinked to
this wrapper in a postinstall action when the RPM is installed.
The wrapper does some minimal checking, issues a big fat warning
and then executes the script under its new name.
@ndokos ndokos force-pushed the wip-rename-util-scripts branch from 7ff4534 to dc3c02a Compare February 5, 2016 21:33
ndokos added a commit that referenced this pull request Feb 5, 2016
Rename util scripts to avoid collisions.
@ndokos ndokos merged commit d8e2104 into distributed-system-analysis:master Feb 5, 2016
@ndokos ndokos removed the in progress label Feb 5, 2016
@ndokos ndokos deleted the wip-rename-util-scripts branch February 5, 2016 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants