-
Notifications
You must be signed in to change notification settings - Fork 107
Rename util scripts to avoid collisions. #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename util scripts to avoid collisions. #130
Conversation
b8a0f12 to
13b98f2
Compare
|
We can add symlinks from the old names to the new names for backwards compatibility - and we can do that in the RPM rather than adding them to the repo. After a suitable period, |
|
Not sure how I feel about symlinks. I would expect that people would just continue to use the old names, unless there's a huge warning every time they use the old name. |
|
In this case, I am not in favor of backward compatibility. If they need that, I would suggest that use the existing release. This is a sufficiently large problem for other reasons that I do not think trying to maintain backward compatibility is worth it here. |
|
The travis build is borked - I'm looking into what needs to be done to fix it: $ sudo pip3 install configtools elasticsearch /usr/local/lib/python3.2/dist-packages/pip-8.0.2-py3.2.egg/pip/_vendor/pkg_resources/init.py:87: UserWarning: Support for Python 3.0-3.2 has been dropped. Future versions will fail here. warnings.warn(msg) Traceback (most recent call last): File "/usr/local/bin/pip3", line 9, in File "/usr/lib/python3/dist-packages/pkg_resources.py", line 337, in load_entry_point File "/usr/lib/python3/dist-packages/pkg_resources.py", line 2280, in load_entry_point File "/usr/lib/python3/dist-packages/pkg_resources.py", line 1990, in load File "/usr/local/lib/python3.2/dist-packages/pip-8.0.2-py3.2.egg/pip/init.py", line 15, in File "/usr/local/lib/python3.2/dist-packages/pip-8.0.2-py3.2.egg/pip/vcs/mercurial.py", line 9, in File "/usr/local/lib/python3.2/dist-packages/pip-8.0.2-py3.2.egg/pip/download.py", line 35, in File "/usr/local/lib/python3.2/dist-packages/pip-8.0.2-py3.2.egg/pip/utils/ui.py", line 15, in File "/usr/local/lib/python3.2/dist-packages/pip-8.0.2-py3.2.egg/pip/_vendor/progress/bar.py", line 48 SyntaxError: invalid syntax |
|
Re: backward compatibility - we could add a script that would take an old name, issue a big fat warning and call the new name, as Andrew suggests. If we don't provide BC, we are basically saying that if you want the new release, you have to go modify your scripts first. It seems to me that the transition would be harder that way. |
|
As long as we have the warning, I think that will be ok. |
e15e881 to
7ff4534
Compare
All the util scripts now have a prefix of pbench-. Move non-pbench scripts to contrib/ subdirectory. contrib/ is not added to the PATH so there will be no collision. If users want to use one or more of these, they will need to call them by full pathname or add contrib/ to their PATH. Add a backward-compatibility wrapper temporarily. We maintain compatibility with the old util-scripts names *for one release only*. The old names will be symlinked to this wrapper in a postinstall action when the RPM is installed. The wrapper does some minimal checking, issues a big fat warning and then executes the script under its new name.
7ff4534 to
dc3c02a
Compare
Rename util scripts to avoid collisions.
All the util scripts now have a prefix of pbench-.
#64