Skip to content

CODE REVIEW CHANGES #1835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 1, 2020
Merged

CODE REVIEW CHANGES #1835

merged 2 commits into from
Oct 1, 2020

Conversation

@Maxusmusti
Copy link
Member

@Maxusmusti Maxusmusti commented Oct 1, 2020

These are the changes specified for tool-meister branch

dbutenhof
dbutenhof approved these changes Oct 1, 2020
View reviewed changes
@portante portante added this to the v0.70 milestone Oct 1, 2020
@portante portante added Agent enhancement tools Of and related to the operation and behavior of various tools (iostat, sar, etc.) labels Oct 1, 2020
dbutenhof
dbutenhof approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

ndokos
ndokos requested changes Oct 1, 2020
View reviewed changes
Copy link
Member

@ndokos ndokos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one minor comment.

@portante portante mentioned this pull request Oct 1, 2020
Merged
portante
portante approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@portante portante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@portante portante merged commit 4b36454 into distributed-system-analysis:tool-meister Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndokos ndokos ndokos requested changes

@portante portante portante approved these changes

@npalaska npalaska npalaska approved these changes

@dbutenhof dbutenhof dbutenhof approved these changes

Assignees

@Maxusmusti Maxusmusti

Labels

Agent enhancement tools Of and related to the operation and behavior of various tools (iostat, sar, etc.)

Projects

None yet

Milestone

v0.70

Development

Successfully merging this pull request may close these issues.

5 participants

@Maxusmusti @ndokos @portante @npalaska @dbutenhof