Skip to content

Updated benchmarks with init/end #1862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2020
Merged

Updated benchmarks with init/end #1862

merged 1 commit into from
Oct 9, 2020

Conversation

@Maxusmusti
Copy link
Member

@Maxusmusti Maxusmusti commented Oct 8, 2020

No description provided.

@Maxusmusti Maxusmusti changed the title Updated benchmarks wit init/end Updated benchmarks with init/end Oct 8, 2020
@Maxusmusti Maxusmusti self-assigned this Oct 8, 2020
@Maxusmusti Maxusmusti requested a review from portante October 8, 2020 23:56
@portante portante added this to the v0.70 milestone Oct 9, 2020
@portante portante added tools Of and related to the operation and behavior of various tools (iostat, sar, etc.) enhancement labels Oct 9, 2020
@portante portante requested a review from ndokos October 9, 2020 00:02
portante
portante approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@portante portante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

portante
portante requested changes Oct 9, 2020
View reviewed changes
Copy link
Member

@portante portante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase, though.

@Maxusmusti
Copy link
Member Author

Maxusmusti commented Oct 9, 2020

Rebased

portante
portante approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@portante portante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

ndokos
ndokos approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@ndokos ndokos left a comment •
edited by portante
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit: we try to standardize on the use of the quoted-and-bracketed form for variable access: ${foo}.

@portante portante merged commit 79086b4 into distributed-system-analysis:master Oct 9, 2020
@portante
Copy link
Member

portante commented Oct 9, 2020

Minor nit: we try to standardize on the use of the quoted-and-bracketed form for variable access: ${foo}.

Much of the surrounding code has the same references style, so it seems worth merging this as is since this was a glaring omission, and then we can fix the variable references up later.

@portante portante linked an issue Oct 12, 2020 that may be closed by this pull request
Need to add pbench-init/end-tools calls in other benchmarks #1857
Closed
@portante portante mentioned this pull request Oct 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndokos ndokos ndokos approved these changes

@portante portante portante approved these changes

Assignees

@Maxusmusti Maxusmusti

Labels

Agent enhancement tools Of and related to the operation and behavior of various tools (iostat, sar, etc.)

Projects

None yet

Milestone

v0.70

Development

Successfully merging this pull request may close these issues.

Need to add pbench-init/end-tools calls in other benchmarks

3 participants

@Maxusmusti @portante @ndokos