Add hostname and IP address validation for env #2207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndokos
requested changes
Apr 8, 2021
ndokos
requested changes
Apr 8, 2021
portante
force-pushed
the
validate-hostname
branch
from
6a07a82 to
3de19c6
Compare
ndokos
previously approved these changes
Apr 8, 2021
portante
commented
Apr 8, 2021
portante
force-pushed
the
validate-hostname
branch
from
3de19c6 to
82212e6
Compare
portante
commented
Apr 8, 2021
portante
commented
Apr 8, 2021
Member
Author
portante
left a comment
portante
left a comment
There was a problem hiding this comment.
Okay, now it is ready for re-review.
portante
force-pushed
the
validate-hostname
branch
from
82212e6 to
c941abb
Compare
From issue distributed-system-analysis#2201, it became apparent that we weren't validating hostnames, which led to weird, but valid, directory names for controllers being created on the server. One way this occurs is when the `_pbench_hostname` and or `_pbench_full_hostname` environment variables are defined with invalid values. We add the new commands `validate-hostname` and `validate-ipaddress` to ensure the definition of those names are correct. In the process of doing that, we found that we were using invalid host names in two of our unit tests.
portante
force-pushed
the
validate-hostname
branch
from
c941abb to
6c01204
Compare
dbutenhof
approved these changes
Apr 9, 2021
ndokos
approved these changes
Apr 9, 2021
webbnh
approved these changes
Apr 9, 2021
Member
webbnh
left a comment
webbnh
left a comment
There was a problem hiding this comment.
Looks good, but before you merge we need to decide how to dispose of the issue below (see my comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From issue #2201, it became apparent that we weren't validating hostnames, which led to weird, but valid, directory names for
controllers being created on the server. One way this occurs is when the
_pbench_hostnameand or_pbench_full_hostnameenvironment variables are defined with invalid values.We add the new commands
validate-hostnameandvalidate-ipaddressto ensure the definition of those names are correct.In the process of doing that, we found that we were using invalid host names in two of our unit tests.
Derived from PR #2181.