Enable minimum RPM version support #2210

portante · 2021-04-10T01:33:05Z

We need to support a minimum version of an RPM in addition to an exact version. We use the rpmdev-vercmp from the rpmdevtools RPM in order to perform the matching.

webbnh

Dmnt, apparently I failed to push "submit" on this a few hours ago.

Now I gotta go review the updates.

agent/bench-scripts/pbench-dbench

agent/bench-scripts/test-bin/require-rpm

agent/bench-scripts/tests/pbench-trafficgen/test-40.txt

agent/tool-scripts/base-tool

agent/util-scripts/require-rpm

webbnh · 2021-04-12T19:36:23Z

OK, apparently I was confused -- there are no updates.

So, my principal concern is with how these changes will work when the arguments to require-rpm are empty or missing. If you're comfortable with those details (and the rest of the nits I picked out), then I can change to "Approved".

agent/util-scripts/require-rpm

agent/base

webbnh

It all looks good except for the quotation problem with the command substitution invocation of require-rpm that we discussed above.

agent/util-scripts/require-rpm

portante

Lots of test file changes, but this now seems complete and ready for a file review.

webbnh

I found a few small things, and I have a couple of suggestions, but I'll leave them up to you.

agent/util-scripts/require-rpm

agent/util-scripts/test-bin/rpm

agent/util-scripts/test-bin/rpmdev-vercmp

agent/bench-scripts/test-bin/require-rpm

agent/util-scripts/require-rpm

webbnh

Good to go, more or less.

I have a bunch of concerns about the rpmdev-vercmp mock, but I'm hoping that they stem from my misunderstanding what it is supposed to do...in which case, maybe it needs better documentation.

agent/util-scripts/test-bin/rpmdev-vercmp

portante

Okay, it was silly to include a mock of rpmdev-vercmp ...

portante · 2021-04-17T02:03:43Z

Bugger all ... I have to rebuild the pbench-devel image with rpmdevtools ... updating shortly.

Fixes distributed-system-analysis#2142. We need to support a minimum version of an RPM in addition to an exact version. We use the `rpmdev-vercmp` from the `rpmdevtools` RPM in order to perform the matching.

portante · 2021-04-17T03:10:20Z

Ran afoul of #2226.

webbnh

Assuming that agent/bench-scripts/pbench-fio's days are numbered, this is good to go, although I've got a pointed question and a couple of nits for your consideration.

agent/bench-scripts/pbench-fio

agent/bench-scripts/test-bin/require-rpm

agent/util-scripts/gold/test-client-tool-meister/test-56.txt

agent/util-scripts/require-rpm

portante · 2021-04-20T23:54:22Z

Bugger all, failed to squash before merging, will address in another PR. Bummer.

portante · 2021-04-21T00:04:08Z

Replaced by #2234.

portante added bug Agent fio pbench-fio benchmark related uperf pbench-uperf benchmark related tools Of and related to the operation and behavior of various tools (iostat, sar, etc.) packaging Issues related to software packaging labels Apr 10, 2021

portante added this to the v0.71 milestone Apr 10, 2021

portante self-assigned this Apr 10, 2021

portante force-pushed the allow-ver-cmp branch from 5c60b27 to ff06c46 Compare April 12, 2021 14:37

portante requested review from ndokos and webbnh April 12, 2021 14:47

portante force-pushed the allow-ver-cmp branch from ff06c46 to 568f01a Compare April 12, 2021 17:40

webbnh reviewed Apr 12, 2021

View reviewed changes

ndokos requested changes Apr 12, 2021

View reviewed changes

agent/util-scripts/require-rpm Outdated Show resolved Hide resolved

agent/util-scripts/require-rpm Outdated Show resolved Hide resolved

portante commented Apr 12, 2021

View reviewed changes

agent/base Outdated Show resolved Hide resolved

portante requested review from ndokos and webbnh April 12, 2021 22:13

webbnh requested changes Apr 13, 2021

View reviewed changes

agent/util-scripts/require-rpm Outdated Show resolved Hide resolved

agent/util-scripts/require-rpm Outdated Show resolved Hide resolved

ndokos previously approved these changes Apr 13, 2021

View reviewed changes

portante dismissed ndokos’s stale review via 2747cec April 15, 2021 03:52

portante force-pushed the allow-ver-cmp branch from f7facfb to 2747cec Compare April 15, 2021 03:52

portante commented Apr 15, 2021

View reviewed changes

portante mentioned this pull request Apr 15, 2021

Don't validate params for pbench-fio install #2219

Merged

webbnh previously approved these changes Apr 15, 2021

View reviewed changes

portante dismissed webbnh’s stale review via 0306f30 April 15, 2021 23:11

portante force-pushed the allow-ver-cmp branch from 2747cec to 0306f30 Compare April 15, 2021 23:11

portante requested review from ndokos and webbnh April 15, 2021 23:12

portante mentioned this pull request Apr 15, 2021

Refactor agent legacy tests to use a shared directory for mocks #2224

Open

webbnh previously approved these changes Apr 16, 2021

View reviewed changes

ndokos previously approved these changes Apr 16, 2021

View reviewed changes

agent/util-scripts/test-bin/rpmdev-vercmp Outdated Show resolved Hide resolved

portante dismissed stale reviews from ndokos and webbnh via cc5957a April 16, 2021 23:09

portante force-pushed the allow-ver-cmp branch 2 times, most recently from cc5957a to 42a84e1 Compare April 16, 2021 23:14

portante commented Apr 16, 2021

View reviewed changes

portante requested review from ndokos and webbnh April 16, 2021 23:16

portante added 9 commits April 16, 2021 23:03

Ensure we always pull jenkins devel images

caada7f

Use Python3 for dcgm-exporter mock

c8b9209

Remove unused check_enable_copr from base

aa3906a

Enable minimum RPM version support

497a158

Fixes distributed-system-analysis#2142. We need to support a minimum version of an RPM in addition to an exact version. We use the `rpmdev-vercmp` from the `rpmdevtools` RPM in order to perform the matching.

Apply code-review feedback

ebd2dd1

Add any match; add more thorough unit tests

77c4aae

apply another round of code-review feedback

1977e13

Enhance doc of rpmdev-vercmp; fix output

b300a95

Mocking rpmdev-vercmp was over-engineering

dc3d63e

portante force-pushed the allow-ver-cmp branch from 7e19532 to dc3d63e Compare April 17, 2021 03:04

webbnh approved these changes Apr 19, 2021

View reviewed changes

agent/bench-scripts/pbench-fio Show resolved Hide resolved

agent/bench-scripts/test-bin/require-rpm Show resolved Hide resolved

agent/util-scripts/gold/test-client-tool-meister/test-56.txt Show resolved Hide resolved

agent/util-scripts/require-rpm Show resolved Hide resolved

ndokos approved these changes Apr 20, 2021

View reviewed changes

portante mentioned this pull request Apr 20, 2021

Refactor code in pbench-fio depending on long-term support options #2233

Open

portante merged commit eca8e44 into distributed-system-analysis:main Apr 20, 2021

portante mentioned this pull request Apr 20, 2021

Enable minimum RPM version support #2234

Merged

portante mentioned this pull request Apr 21, 2021

Need to allow pbench-fio to match newer versions rather than exact #2142

Closed

Enable minimum RPM version support #2210

Enable minimum RPM version support #2210

Uh oh!

Conversation

portante commented Apr 10, 2021

Uh oh!

webbnh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

webbnh commented Apr 12, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

webbnh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

portante left a comment

Choose a reason for hiding this comment

Uh oh!

webbnh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

webbnh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

portante left a comment

Choose a reason for hiding this comment

Uh oh!

portante commented Apr 17, 2021

Uh oh!

portante commented Apr 17, 2021

Uh oh!

webbnh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

portante commented Apr 20, 2021

Uh oh!

portante commented Apr 21, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants