pbench-agent.cfg is no longer a ghost #2389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes distributed-system-analysis#2343 (again and finally) The example config file was renamed in PR distributed-system-analysis#2358, but there is still a problem: tHe %ghost line in the spec file is preventing its installation. This PR fixes that.
dbutenhof
approved these changes
Jul 27, 2021
Member
dbutenhof
left a comment
dbutenhof
left a comment
There was a problem hiding this comment.
Looks good. I had to check the documentation to be sure I understood what %ghost was doing, and I wonder if we should use %config(noreplace) instead so we don't overwrite a modified config file on upgrade... but that's a separate issue.
riya-17
approved these changes
Jul 27, 2021
webbnh
approved these changes
Jul 27, 2021
portante
reviewed
Jul 29, 2021
This was referenced Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2343 (again and finally)
The example config file was renamed in PR #2358, but there is still a problem: the %ghost line in the spec file is preventing its installation. This PR fixes that.