Stop explicitly manipulating firewalls in pbench-fio and pbench-uperf
#2524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
portante
force-pushed
the
remove-firewall-cmd
branch
2 times, most recently
from
a489f9e to
c6afaaf
Compare
dbutenhof
previously approved these changes
Nov 4, 2021
webbnh
requested changes
Nov 4, 2021
portante
added a commit
to portante/pbench
that referenced
this pull request
Nov 5, 2021
Originally part of PR distributed-system-analysis#2524, we correct the usage output to be emitted on `stderr` in error conditions, and to `stdout` for the one non-error condition, `--help`. Further we remove the annoying trailing semi-colons, and remove the extra `shift` statement while processing options. Lastly, unrecognized parameters now cause an error.
|
FWIW, I created PR #2526 to track the |
portante
force-pushed
the
remove-firewall-cmd
branch
from
c6afaaf to
81576a5
Compare
|
I've decided to convert this to a |
dbutenhof
previously approved these changes
Nov 5, 2021
webbnh
pushed a commit
that referenced
this pull request
Nov 5, 2021
Originally part of PR #2524, we correct the usage output to be emitted on `stderr` in error conditions, and to `stdout` for the one non-error condition, `--help`. Further we remove the annoying trailing semi-colons, and remove the extra `shift` statement while processing options. Lastly, unrecognized parameters now cause an error.
portante
force-pushed
the
remove-firewall-cmd
branch
2 times, most recently
from
7cc3b26 to
e446b74
Compare
dbutenhof
previously approved these changes
Nov 5, 2021
All three existing benchmark scripts which manipulate network firewalls have been changed to ignore firewalls entirely. For `pbench-fio`, this means it no longer attempts to add open ports when clients are used. For `pbench-uperf` and `pbench-netperf`, those scripts no longer disable `firewalld` explicitly. Any one using `pbench-fio` in client mode, or either `pbench-uperf` or `pbench-netperf`, must be responsible for properly enabling access on the expected ports. The documentation for `pbench-uperf` and `pbench-fio` have been updated to reflect this new behavior.
portante
force-pushed
the
remove-firewall-cmd
branch
from
e446b74 to
2f977ae
Compare
dbutenhof
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All three existing benchmark scripts which manipulate network firewalls have been changed to ignore firewalls entirely.
For
pbench-fio, this means it no longer attempts to add open ports when clients are used.For
pbench-uperfandpbench-netperf, those scripts no longer disablefirewalldexplicitly.Any one using
pbench-fioin client mode, or eitherpbench-uperforpbench-netperf, must be responsible for properly enabling access on the expected ports.The documentation for
pbench-uperfandpbench-fiohave been updated to reflect this new behavior.Fixed #1217.