Skip to content

Stop explicitly manipulating firewalls in pbench-fio and pbench-uperf #2524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Stop explicitly manipulating firewalls in pbench-fio and pbench-uperf #2524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions agent/bench-scripts/pbench-fio
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,11 +603,6 @@ function fio_run_job() {
ssh ${ssh_opts} ${client} mkdir -p ${benchmark_results_dir} &
done
wait
debug_log "opening client port in firewall on the clients"
for client in "${client_names[@]}"; do
ssh ${ssh_opts} ${client} "firewall-cmd --add-port=${client_ports[${client}]}/tcp >/dev/null" &
done
wait
debug_log "killing any old fio process on the clients"
for client in "${client_names[@]}"; do
ssh ${ssh_opts} ${client} "killall fio >/dev/null 2>&1" &
Expand Down
25 changes: 25 additions & 0 deletions agent/bench-scripts/pbench-fio.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,3 +339,28 @@ Here are the pbench-fio parameters:
* **--numjobs=uint** - the total number of "jobs" to run. This is typically set to the number of clients above. Typically in the job file, you use numjobs=1.
* **--pre-iteration-script=path** - this points to a local executable script (doesn't have to be bash) that will execute before each sample is run. For an example of how this can be useful, see cache-dropping section above.
* **--max-stddev=uint** - maximum percent deviation (100.0 \* standard deviation / mean) allowed for a successful test. If you get test failures, consider either lengthening your test, changing test procedure to improve repeatability, or increasing this parameter. Default is 5%.


## firewalls

*You must ensure that the network firewall is not up, or poke holes in the firewall
for pbench-fio when using remote clients*. Typically there are two possible
firewall implementations encountered:

* the **firewalld** service
* the **iptables** service

To temporarily disable (this may give security folks heartburn):

# systemctl stop firewalld
# systemctl stop iptables

To temporarily enable port under firewalld use:

# firewall-cmd --add-port=8765/tcp

Where "8765" is the default port pbench-fio will use for the fio clients.
If you are using multiple clients, without specifying explicit ports, and using
the `--unique-ports` switch, then starting with port 8765, pbench-fio will use
sequential ports for each client. Be sure you open those ports on the remote
systems ahead of time.
5 changes: 1 addition & 4 deletions agent/bench-scripts/pbench-netperf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,9 +471,7 @@ for protocol in `echo $protocols | sed -e s/,/" "/g`; do
if [ "$postprocess_only" != "y" ]; then
# prepare the netperf server(s)
for server in `echo $servers | sed -e s/,/" "/g`; do
ssh $ssh_opts $server killall netperf
ssh $ssh_opts $server "systemctl stop firewalld"
ssh $ssh_opts $server "screen -dmS netperf-server /usr/bin/netperf -s"
ssh $ssh_opts $server "killall netperf; screen -dmS netperf-server /usr/bin/netperf -s"
done
# prepare test files and dirs if using remote clients
if [ ! -z "$clients" ]; then
Expand All @@ -483,7 +481,6 @@ for protocol in `echo $protocols | sed -e s/,/" "/g`; do
xml_file="$benchmark_run_dir/$iteration/netperf-config-$server.xml"
ssh $ssh_opts $client mkdir -p $benchmark_results_dir
scp $scp_opts $xml_file $client:$xml_file
ssh $ssh_opts $client "systemctl stop firewalld"
let i=$i+1
done
wait
Expand Down
2 changes: 0 additions & 2 deletions agent/bench-scripts/pbench-uperf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,7 +632,6 @@ for protocol in `echo $protocols | sed -e s/,/" "/g`; do
ssh $ssh_opts $client mkdir -p $benchmark_results_dir
scp $scp_opts $xml_file $client:$xml_file >/dev/null
scp $scp_opts $benchmark_client_cmd_file $client:$benchmark_client_cmd_file >/dev/null
ssh $ssh_opts $client "systemctl stop firewalld"
fi

# prepare test files and dirs on servers
Expand All @@ -641,7 +640,6 @@ for protocol in `echo $protocols | sed -e s/,/" "/g`; do

# start the uperf server(s)
stop_server $server $server_port 1
ssh $ssh_opts $server "systemctl stop firewalld"
ssh $ssh_opts $server "screen -dmS uperf-server $benchmark_server_cmd_file"

((server_nr++))
Expand Down
16 changes: 14 additions & 2 deletions agent/bench-scripts/pbench-uperf.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,16 +79,28 @@ they only have to allow password-less ssh access from the head node.

## firewalls

*you must ensure that the network firewall or poke holes in the firewall for pbench-uperf*. Typically there are two possible firewall implementations encountered:
*You must ensure that the network firewall is not up, or poke holes in the firewall
for pbench-uperf*. Typically there are two possible firewall implementations
encountered:

* the **firewalld** service
* the **iptables** service

to temporarily disable (this may give security folks heartburn):
To temporarily disable (this may give security folks heartburn):

# systemctl stop firewalld
# systemctl stop iptables

To temporarily enable port under firewalld use:

# firewall-cmd --add-port=20000/tcp

Where "20000" is the default port pbench-uperf will use for the uperf server.
If you are using multiple servers, then starting with port 20000, pbench-uperf
will use ports in increments of 10. E.g. for 3 client / server pairs, ports
ports 20000, 20010, and 20020 will be used. Be sure you open those ports on
the remote systems ahead of time.

## syntax

Important test parameters are listed in their long form but there is also a short form available with **-h** :
Expand Down
9 changes: 0 additions & 9 deletions agent/bench-scripts/tests/pbench-fio/test-05.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,6 @@ fio job complete
[debug][1900-01-01T00:00:00.000000] verifying clients have fio installed
[debug][1900-01-01T00:00:00.000000] fio_device_check(devs="/tmp/fio", clients="foo,bar")
[debug][1900-01-01T00:00:00.000000] creating directories on the clients
[debug][1900-01-01T00:00:00.000000] opening client port in firewall on the clients
[debug][1900-01-01T00:00:00.000000] killing any old fio process on the clients
[debug][1900-01-01T00:00:00.000000] starting new fio process on the clients
[debug][1900-01-01T00:00:00.000000] waiting for fio process(server) to start on clients
Expand All @@ -155,7 +154,6 @@ fio job complete
[debug][1900-01-01T00:00:00.000000] post-processing tool data
[debug][1900-01-01T00:00:00.000000] post-processing fio result
[debug][1900-01-01T00:00:00.000000] creating directories on the clients
[debug][1900-01-01T00:00:00.000000] opening client port in firewall on the clients
[debug][1900-01-01T00:00:00.000000] killing any old fio process on the clients
[debug][1900-01-01T00:00:00.000000] starting new fio process on the clients
[debug][1900-01-01T00:00:00.000000] waiting for fio process(server) to start on clients
Expand All @@ -166,7 +164,6 @@ fio job complete
[debug][1900-01-01T00:00:00.000000] post-processing tool data
[debug][1900-01-01T00:00:00.000000] post-processing fio result
[debug][1900-01-01T00:00:00.000000] creating directories on the clients
[debug][1900-01-01T00:00:00.000000] opening client port in firewall on the clients
[debug][1900-01-01T00:00:00.000000] killing any old fio process on the clients
[debug][1900-01-01T00:00:00.000000] starting new fio process on the clients
[debug][1900-01-01T00:00:00.000000] waiting for fio process(server) to start on clients
Expand Down Expand Up @@ -207,9 +204,6 @@ fio job complete
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no bar cd /var/tmp/pbench-test-bench/pbench-agent/fio_test-05_1900.01.01T00.00.00/1-rw-4KiB/sample1 && screen -dmS fio-server bash -c '/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/bm --server=,8765 2>&1 >client-result.txt'
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no bar cd /var/tmp/pbench-test-bench/pbench-agent/fio_test-05_1900.01.01T00.00.00/2-rw-64KiB/sample1 && screen -dmS fio-server bash -c '/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/bm --server=,8765 2>&1 >client-result.txt'
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no bar cd /var/tmp/pbench-test-bench/pbench-agent/fio_test-05_1900.01.01T00.00.00/3-rw-1024KiB/sample1 && screen -dmS fio-server bash -c '/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/bm --server=,8765 2>&1 >client-result.txt'
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no bar firewall-cmd --add-port=8765/tcp >/dev/null
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no bar firewall-cmd --add-port=8765/tcp >/dev/null
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no bar firewall-cmd --add-port=8765/tcp >/dev/null
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no bar killall fio >/dev/null 2>&1
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no bar killall fio >/dev/null 2>&1
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no bar killall fio >/dev/null 2>&1
Expand All @@ -220,9 +214,6 @@ fio job complete
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no foo cd /var/tmp/pbench-test-bench/pbench-agent/fio_test-05_1900.01.01T00.00.00/1-rw-4KiB/sample1 && screen -dmS fio-server bash -c '/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/bm --server=,8765 2>&1 >client-result.txt'
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no foo cd /var/tmp/pbench-test-bench/pbench-agent/fio_test-05_1900.01.01T00.00.00/2-rw-64KiB/sample1 && screen -dmS fio-server bash -c '/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/bm --server=,8765 2>&1 >client-result.txt'
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no foo cd /var/tmp/pbench-test-bench/pbench-agent/fio_test-05_1900.01.01T00.00.00/3-rw-1024KiB/sample1 && screen -dmS fio-server bash -c '/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/bm --server=,8765 2>&1 >client-result.txt'
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no foo firewall-cmd --add-port=8765/tcp >/dev/null
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no foo firewall-cmd --add-port=8765/tcp >/dev/null
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no foo firewall-cmd --add-port=8765/tcp >/dev/null
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no foo killall fio >/dev/null 2>&1
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no foo killall fio >/dev/null 2>&1
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no foo killall fio >/dev/null 2>&1
Expand Down
12 changes: 0 additions & 12 deletions agent/bench-scripts/tests/pbench-fio/test-06.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,6 @@ fio job complete
[debug][1900-01-01T00:00:00.000000] verifying clients have fio installed
[debug][1900-01-01T00:00:00.000000] fio_device_check(devs="/tmp/fio", clients="foo,bar,baz")
[debug][1900-01-01T00:00:00.000000] creating directories on the clients
[debug][1900-01-01T00:00:00.000000] opening client port in firewall on the clients
[debug][1900-01-01T00:00:00.000000] killing any old fio process on the clients
[debug][1900-01-01T00:00:00.000000] starting new fio process on the clients
[debug][1900-01-01T00:00:00.000000] waiting for fio process(server) to start on clients
Expand All @@ -162,7 +161,6 @@ fio job complete
[debug][1900-01-01T00:00:00.000000] post-processing tool data
[debug][1900-01-01T00:00:00.000000] post-processing fio result
[debug][1900-01-01T00:00:00.000000] creating directories on the clients
[debug][1900-01-01T00:00:00.000000] opening client port in firewall on the clients
[debug][1900-01-01T00:00:00.000000] killing any old fio process on the clients
[debug][1900-01-01T00:00:00.000000] starting new fio process on the clients
[debug][1900-01-01T00:00:00.000000] waiting for fio process(server) to start on clients
Expand All @@ -174,7 +172,6 @@ fio job complete
[debug][1900-01-01T00:00:00.000000] post-processing tool data
[debug][1900-01-01T00:00:00.000000] post-processing fio result
[debug][1900-01-01T00:00:00.000000] creating directories on the clients
[debug][1900-01-01T00:00:00.000000] opening client port in firewall on the clients
[debug][1900-01-01T00:00:00.000000] killing any old fio process on the clients
[debug][1900-01-01T00:00:00.000000] starting new fio process on the clients
[debug][1900-01-01T00:00:00.000000] waiting for fio process(server) to start on clients
Expand Down Expand Up @@ -216,9 +213,6 @@ fio job complete
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no bar cd /var/tmp/pbench-test-bench/pbench-agent/fio_test-06_1900.01.01T00.00.00/1-rw-4KiB/sample1 && screen -dmS fio-server bash -c '/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/bm --server=,8765 2>&1 >client-result.txt'
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no bar cd /var/tmp/pbench-test-bench/pbench-agent/fio_test-06_1900.01.01T00.00.00/2-rw-64KiB/sample1 && screen -dmS fio-server bash -c '/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/bm --server=,8765 2>&1 >client-result.txt'
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no bar cd /var/tmp/pbench-test-bench/pbench-agent/fio_test-06_1900.01.01T00.00.00/3-rw-1024KiB/sample1 && screen -dmS fio-server bash -c '/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/bm --server=,8765 2>&1 >client-result.txt'
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no bar firewall-cmd --add-port=8765/tcp >/dev/null
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no bar firewall-cmd --add-port=8765/tcp >/dev/null
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no bar firewall-cmd --add-port=8765/tcp >/dev/null
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no bar killall fio >/dev/null 2>&1
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no bar killall fio >/dev/null 2>&1
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no bar killall fio >/dev/null 2>&1
Expand All @@ -229,9 +223,6 @@ fio job complete
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no baz cd /var/tmp/pbench-test-bench/pbench-agent/fio_test-06_1900.01.01T00.00.00/1-rw-4KiB/sample1 && screen -dmS fio-server bash -c '/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/bm --server=,8765 2>&1 >client-result.txt'
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no baz cd /var/tmp/pbench-test-bench/pbench-agent/fio_test-06_1900.01.01T00.00.00/2-rw-64KiB/sample1 && screen -dmS fio-server bash -c '/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/bm --server=,8765 2>&1 >client-result.txt'
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no baz cd /var/tmp/pbench-test-bench/pbench-agent/fio_test-06_1900.01.01T00.00.00/3-rw-1024KiB/sample1 && screen -dmS fio-server bash -c '/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/bm --server=,8765 2>&1 >client-result.txt'
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no baz firewall-cmd --add-port=8765/tcp >/dev/null
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no baz firewall-cmd --add-port=8765/tcp >/dev/null
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no baz firewall-cmd --add-port=8765/tcp >/dev/null
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no baz killall fio >/dev/null 2>&1
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no baz killall fio >/dev/null 2>&1
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no baz killall fio >/dev/null 2>&1
Expand All @@ -242,9 +233,6 @@ fio job complete
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no foo cd /var/tmp/pbench-test-bench/pbench-agent/fio_test-06_1900.01.01T00.00.00/1-rw-4KiB/sample1 && screen -dmS fio-server bash -c '/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/bm --server=,8765 2>&1 >client-result.txt'
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no foo cd /var/tmp/pbench-test-bench/pbench-agent/fio_test-06_1900.01.01T00.00.00/2-rw-64KiB/sample1 && screen -dmS fio-server bash -c '/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/bm --server=,8765 2>&1 >client-result.txt'
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no foo cd /var/tmp/pbench-test-bench/pbench-agent/fio_test-06_1900.01.01T00.00.00/3-rw-1024KiB/sample1 && screen -dmS fio-server bash -c '/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/bm --server=,8765 2>&1 >client-result.txt'
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no foo firewall-cmd --add-port=8765/tcp >/dev/null
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no foo firewall-cmd --add-port=8765/tcp >/dev/null
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no foo firewall-cmd --add-port=8765/tcp >/dev/null
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no foo killall fio >/dev/null 2>&1
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no foo killall fio >/dev/null 2>&1
/var/tmp/pbench-test-bench/opt/pbench-agent/unittest-scripts/ssh -o BatchMode=yes -o StrictHostKeyChecking=no foo killall fio >/dev/null 2>&1
Expand Down
Loading