Rework the agent functional tests #2648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
portante
force-pushed
the
rework-func-tests
branch
from
eb1db1c to
f4a493b
Compare
This was referenced Feb 26, 2022
dbutenhof
reviewed
Feb 28, 2022
webbnh
previously approved these changes
Feb 28, 2022
portante
force-pushed
the
rework-func-tests
branch
4 times, most recently
from
0107fc1 to
0153260
Compare
The functional tests were only for the agent. There is no need to run them for the server side. This partially fixes distributed-system-analysis#2647 by always having an agent environment for the functional tests.
portante
force-pushed
the
rework-func-tests
branch
from
0153260 to
d35f6de
Compare
dbutenhof
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functional tests were only for the agent. There is no need to run them for the server side.
This partially fixes issue #2647 by always having an agent environment for the functional tests.
This is foundational work for PR #2551.