Skip to content

Fix condition for warning of already running tools. #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2016
Merged

Fix condition for warning of already running tools. #284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion agent/tool-scripts/kvm-spinlock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ function safe_kill() {
done
# hack: individual tools will have a different number of pids running.
# we might just delete the warning if it gets too cumbersome.
if [ $len -ge 4 -o $len -ge 3 -a $tool!="turbostat" ] ;then
if [[ $len > 4 || ($len > 3 && $tool != "turbostat") ]] ;then
warn_log "Too many pids for $tool: $pidlist -- maybe old tools running? Use pbench-kill-tools."
fi

Expand Down