More backports for b0.71
#2867
Merged
More backports for b0.71
#2867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
portante
added
bug
Agent
fio
portante
force-pushed
the
set-02-backports-for-b0.71
branch
from
3969812 to
08fcd92
Compare
dbutenhof
previously approved these changes
May 25, 2022
webbnh
previously approved these changes
May 25, 2022
Member
webbnh
left a comment
webbnh
left a comment
There was a problem hiding this comment.
Looks OK to me (although, I skipped the unit tests...).
I have one comment which is probably better applied to main, but I only noticed it here.
This is a back-port of commit ba6a2b7 (PR distributed-system-analysis#2860) from `main`. Both `pbench-fio` and `pbench-uperf`: * No longer allow for the benchmark binary to be overriden by an environment variable -- this was an out-dated way for the unit tests to mock the respective benchmark behavior * No longer resolve and check that the benchmark binary is executable There was an ordering problem with the old `benchmark_bin` variable initial value and where it is used in the rest of the script (both for `pbench-fio` and `pbench-uperf`). The existence check was not always performed locally (no clients or servers specified which are local), but the commands run remotely required `benchmark_bin` to be set during creation of the commands for remote execution. By only checking for the existence of the benchmark binary when performing the version check, and allowing the shell to resolve the location of the benchmark binary at run time, we avoid the interdependency altogether. Mock commands for `fio` and `uperf` are provided on the `PATH` for tests. For the CLI tests, those mocks are removed so that we can verify that help and usage text is emitted before the checks for the particular command existence (which is shown by the failing `test-CL`). We also add failing tests for `uperf` and `fio` behaviors: * `pbench-fio` * `test-22` -- missing `fio` command * `test-50` -- `fio -V` reports a bad version * `pbench-uperf` * `test-02` -- missing `uperf` command * `test-51` -- `uperf -V` reports a bad version The existence check of the `fio` and `uperf` benchmark commands now occurs after any help requests or command usage errors. This fixes issue distributed-system-analysis#2841 [1]. Finally, we correct the way `pbench-uperf` checked the status of the `uperf` command execution of the benchmark by making sure the `local` declaration is performed before the assigment, so that the return code check is not overridden by the "status" of the `local` declaration. This fixes issue distributed-system-analysis#2842 [2]. [1] distributed-system-analysis#2841 [2] distributed-system-analysis#2842
This is a back-port of commit b51b116 (PR distributed-system-analysis#2856) from `main`. We add a local and remote pre-check function for linpack. We now wait at most 60 seconds for the linpack process to start, and then we wait for the PID to exit instead of a file to exist. That way if a file is never written that we expect, but the PID has died, we'll not wait forever. Further, we move the "version" check (of sorts) to the linpack driver script to allow for the remote check to work without having the code in two places.
This is a back-port of commit c84c6ed (PR distributed-system-analysis#2863) from `main`. When `pbench-tool-meister-stop` is invoked where the Redis server was created locally by `pbench-tool-meister-start`, we always want to use the `localhost` IP address to talk to it. Also added unit tests for the `tool_meister_stop.py` module's `RedisServer` class, and corrected the `pbench-tool-meister-stop` CLI param default value for the `--redis-server` switch. Fixes issue distributed-system-analysis#2861 [1]. [1] distributed-system-analysis#2861
portante
added a commit
to portante/pbench
that referenced
this pull request
May 25, 2022
The review of the back-port PR distributed-system-analysis#2867 found a couple of minor fixes that also need to be applied to `main`.
portante
added a commit
that referenced
this pull request
May 25, 2022
The review of the back-port PR #2867 found a couple of minor fixes that also need to be applied to `main`.
portante
force-pushed
the
set-02-backports-for-b0.71
branch
from
08fcd92 to
e98c83f
Compare
dbutenhof
approved these changes
May 25, 2022
ndokos
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides back-ports of PRs #2863, #2856, #2860, and #2870.
Note that with the backport of #2860, where the
resolve_benchmark_binfunction was removed fromagent/base, we still have three deprecated commands,pbench-dbench,pbench-iozone, andpbench-netperf, which were referencing that function. Since we don't want to introduce thewhichRPM as a dependency, we just usecommand -vin each of those commands instead.