Ansible fixes b0.72 #3407
Merged
Ansible fixes b0.72 #3407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The argument gives errors now, so delete it.
The pbench repo contains RPMs for pbench-sysstat and screen (the latter for *some* distros, mainly RHEL8 - RHEL9 picks up screen from EPEL). The pbench-<version> repo contains the RPM for the latest release of pbench-agent (and possibly a server RPM although we don't install RPMs for the server: containers have taken over).
webbnh
previously approved these changes
Apr 27, 2023
Member
webbnh
left a comment
webbnh
left a comment
There was a problem hiding this comment.
Looks OK to me as far as I can tell (just so long as the change from username to user was intended...).
Regarding the failing tests....
TestUpload.test_bad_metadata_uploadseems to be failing because of a change to the time format (the test is looking for the time zone offset to be preceded by a+but the error from the Server has a space there);TestServerAudit.test_get_status_startand the other two failing tests are receiving half as many audit events as they are expecting.
But, I don't see how the changes in this PR prompt either of those failure modes...which suggests that something external is biting us again.
agent/ansible/collection/roles/pbench_repo_install/defaults/main.yml
Outdated
Show resolved
Hide resolved
dbutenhof
approved these changes
May 2, 2023
webbnh
approved these changes
May 2, 2023
ndokos
added a commit
to ndokos/pbench
that referenced
this pull request
May 16, 2023
Forward port of distributed-system-analysis#3407 from b0.72. * The `ansible.builtin.command' module does not take a warn argument The argument gives errors now, so delete it. * There are now two repos for pbench-agent The pbench repo contains RPMs for pbench-sysstat and screen (the latter for *some* distros, mainly RHEL8 - RHEL9 picks up screen from EPEL). The pbench-<version> repo contains the RPM for the latest release of pbench-agent (and possibly a server RPM although we don't install RPMs for the server: containers have taken over).
ndokos
added a commit
to ndokos/pbench
that referenced
this pull request
May 16, 2023
Forward port of distributed-system-analysis#3407 from b0.72. * The `ansible.builtin.command' module does not take a warn argument The argument gives errors now, so delete it. * There are now two repos for pbench-agent The pbench repo contains RPMs for pbench-sysstat and screen (the latter for *some* distros, mainly RHEL8 - RHEL9 picks up screen from EPEL). The pbench-<version> repo contains the RPM for the latest release of pbench-agent (and possibly a server RPM although we don't install RPMs for the server: containers have taken over).
Merged
dbutenhof
pushed a commit
that referenced
this pull request
May 17, 2023
Forward port of #3407 from b0.72. * The `ansible.builtin.command' module does not take a warn argument The argument gives errors now, so delete it. * There are now two repos for pbench-agent The pbench repo contains RPMs for pbench-sysstat and screen (the latter for *some* distros, mainly RHEL8 - RHEL9 picks up screen from EPEL). The pbench-<version> repo contains the RPM for the latest release of pbench-agent (and possibly a server RPM although we don't install RPMs for the server: containers have taken over).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3406
commandmodule raises: it does not like thewarnargument any longer, so delete the argument.